Skip to content

Increase SQL workflow ID column length#10179

Open
flemzord wants to merge 3 commits intotemporalio:mainfrom
flemzord:fix/workflow-id-1000-sql
Open

Increase SQL workflow ID column length#10179
flemzord wants to merge 3 commits intotemporalio:mainfrom
flemzord:fix/workflow-id-1000-sql

Conversation

@flemzord
Copy link
Copy Markdown

@flemzord flemzord commented May 5, 2026

What changed

  • Increase SQL workflow ID-related columns to 1000 in PostgreSQL and MySQL schema snapshots and new versioned migrations.
  • Use PostgreSQL VARCHAR(1000) and MySQL VARBINARY(1000) for workflow ID columns.
  • Bump PostgreSQL/MySQL temporal and visibility schema versions.
  • Align development SQL dynamic config max ID length with the 1000 application limit.
  • Add coverage for child workflow IDs at length 1000 and validation rejection at 1001.

Fixes #7506
Fixes #2695

Validation

  • go test -tags test_dep ./schema ./schema/postgresql/v12 ./schema/mysql/v8 ./tools/common/schema
  • go test -tags test_dep ./service/history/api -run 'TestCommandAttrValidatorSuite/TestValidateStartChildExecutionAttributes' -count=1
  • go test -tags test_dep ./tests -run 'TestChildWorkflowSuite/TestStartChildWorkflowWithMaxLengthWorkflowID' -persistenceType=sql -persistenceDriver=mysql8 -count=1
  • POSTGRES_PORT=15432 go test -tags test_dep ./tests -run 'TestChildWorkflowSuite/TestStartChildWorkflowWithMaxLengthWorkflowID' -persistenceType=sql -persistenceDriver=postgres12 -count=1
  • POSTGRES_PORT=15432 go test -tags test_dep ./tests -run 'TestChildWorkflowSuite/TestStartChildWorkflowWithMaxLengthWorkflowID' -persistenceType=sql -persistenceDriver=postgres12_pgx -count=1
  • go test -tags test_dep ./tools/tests -run TestMySQL -count=1
  • POSTGRES_PORT=15432 go test -tags test_dep ./tools/tests -run TestPostgres -count=1
  • make lint-code

@flemzord flemzord requested review from a team as code owners May 5, 2026 13:31
@CLAassistant
Copy link
Copy Markdown

CLAassistant commented May 5, 2026

CLA assistant check
All committers have signed the CLA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Start child with WorkflowID longer than 255 with SQL as persistence would stuck Workflow ID size check mismatch

2 participants