Add flag to skip setting up ES cluster settings#10152
Open
rodrigozhou wants to merge 1 commit intomainfrom
Open
Add flag to skip setting up ES cluster settings#10152rodrigozhou wants to merge 1 commit intomainfrom
rodrigozhou wants to merge 1 commit intomainfrom
Conversation
robholland
approved these changes
May 2, 2026
| if err != nil { | ||
| logger.Error("Unable to load embedded cluster settings.", tag.Error(err)) | ||
| return err | ||
| settingsContent := "" |
Contributor
There was a problem hiding this comment.
Having settingsContent empty will lead to a slightly confusing log message:
temporal/tools/elasticsearch/tasks.go
Line 34 in d277ac1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed?
Add flag to skip setting up ES cluster settings. Eg:
temporal-elasticsearch-tool setup-schema --skip-cluster-settingsWhy?
Allow users to not use our provided cluster settings (eg: avoid overwriting their cluster settings).
#9857
How did you test it?
Potential risks