Draft
Conversation
stephanos
force-pushed
the
stephanos/parallel-versioning
branch
4 times, most recently
from
be92a54 to
7bb6593
Compare
stephanos
commented
May 1, 2026
| farm.Fingerprint32([]byte(fullName)), | ||
| ) | ||
| return strings.Replace(short, ".", "|", -1) | ||
| } |
stephanos
force-pushed
the
stephanos/parallel-versioning
branch
3 times, most recently
from
872c197 to
2ef1d4b
Compare
stephanos
force-pushed
the
stephanos/parallel-versioning
branch
14 times, most recently
from
0fb6440 to
7da0418
Compare
stephanos
commented
May 1, 2026
| } | ||
|
|
||
| func (s *Versioning3Suite) TestSessionActivityResourceSpecificTaskQueueNotRegisteredInVersion() { | ||
| tv := testvars.New(s) | ||
|
|
||
| ctx, cancel := context.WithTimeout(context.Background(), time.Minute) |
Contributor
Author
There was a problem hiding this comment.
one big change here is removing these contexts; they are all placed with simply env.Context() which has a default timeout.
stephanos
commented
May 1, 2026
| @@ -72,124 +70,133 @@ const ( | |||
| versionStatusRamping = versionStatus(3) | |||
| versionStatusDraining = versionStatus(4) | |||
| versionStatusDrained = versionStatus(5) | |||
|
|
|||
| versioning3DeploymentWorkflowVersion = workerdeployment.VersionDataRevisionNumber | |||
Contributor
Author
There was a problem hiding this comment.
parallelsuite doesn't allow fields so this was moved here - it seems to be readonly anyway
stephanos
force-pushed
the
stephanos/parallel-versioning
branch
from
7da0418 to
4dc3841
Compare
stephanos
commented
May 1, 2026
| @@ -1411,7 +1393,7 @@ func (s *Versioning3Suite) testDoubleTransition(unversionedSrc bool, signal bool | |||
| // 8. Not that the transition is complete, the activity should be able to go to sourceV poller. | |||
| // 9. Set v2 as current again and ensure the wf can complete on it. | |||
|
|
|||
| tv1 := testvars.New(s).WithBuildIDNumber(1) | |||
Contributor
Author
There was a problem hiding this comment.
testvars are coming from env now
stephanos
force-pushed
the
stephanos/parallel-versioning
branch
2 times, most recently
from
1a58c19 to
4ac032b
Compare
stephanos
commented
May 1, 2026
| // unique namespaces with overrides per namespace should be used for tests that require overrides. | ||
| defaultDynamicConfigOverrides = map[dynamicconfig.Key]any{ | ||
| dynamicconfig.FrontendRPS.Key(): 3000, | ||
| dynamicconfig.FrontendNamespaceReplicationInducingAPIsRPS.Key(): 1000, |
Contributor
Author
There was a problem hiding this comment.
moved here since it's a global config
stephanos
force-pushed
the
stephanos/parallel-versioning
branch
6 times, most recently
from
11ae0d3 to
22b4ddb
Compare
stephanos
commented
May 1, 2026
| } | ||
|
|
||
| func (s *Versioning3Suite) updateUtils() updateutils.UpdateUtils { | ||
| return updateutils.New(s.T()) | ||
| } | ||
|
|
||
| func (s *Versioning3Suite) TestPinnedTask_NoProperPoller() { |
Contributor
Author
There was a problem hiding this comment.
"Hide Whitespace is required from here on
stephanos
force-pushed
the
stephanos/parallel-versioning
branch
from
22b4ddb to
659b754
Compare
stephanos
force-pushed
the
stephanos/parallel-versioning
branch
from
659b754 to
dc71a2b
Compare
stephanos
force-pushed
the
stephanos/parallel-versioning
branch
from
dc71a2b to
df0bd86
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed?
Migrate Versioning3Suite to use parallelsuite.
Why?
main takes 862s, branch takes 90s.