fix: use allow instead of ignore for dependency-type in dependabot config#1057
Open
chaptersix wants to merge 3 commits into
Open
fix: use allow instead of ignore for dependency-type in dependabot config#1057chaptersix wants to merge 3 commits into
chaptersix wants to merge 3 commits into
Conversation
…nfig dependency-type is only valid inside allow, not ignore. Use allow with dependency-type: direct to exclude indirect deps.
Uses check-jsonschema with the built-in vendor.dependabot schema to catch invalid dependabot.yml configs in PRs and on push to main.
There was a problem hiding this comment.
Pull request overview
Fixes an invalid .github/dependabot.yml introduced in #1044 by replacing the unsupported dependency-type: indirect entry under ignore with an allow: [dependency-type: direct] entry, achieving the same intent (skip indirect/transitive Go updates) in a schema-valid way. Also adds a CI workflow that runs check-jsonschema against the built-in vendor.dependabot schema to catch similar regressions in the future.
Changes:
- Replace invalid
ignore.dependency-type: indirectwithallow.dependency-type: directin.github/dependabot.yml, retaining the Temporal name-based ignore. - Add
.github/workflows/validate-dependabot.ymlthat runscheck-jsonschema --builtin-schema vendor.dependaboton PRs and pushes tomainthat touch.github/dependabot.yml.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| .github/dependabot.yml | Swap invalid ignore entry for an equivalent allow: direct rule. |
| .github/workflows/validate-dependabot.yml | New workflow that validates dependabot.yml against the vendor schema via check-jsonschema. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+20
to
+24
| - uses: actions/checkout@v6 | ||
|
|
||
| - uses: actions/setup-python@v6 | ||
| with: | ||
| python-version: '3.12' |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
dependency-typeis only valid insideallow, notignorein dependabot.ymlignoreentry withallow: [{dependency-type: direct}]to achieve the same goal of skipping indirect/transitive dependency updatescheck-jsonschemato validatedependabot.ymlon PRs and pushes to mainTest plan
.github/dependabot.ymlvalidation check passes on this PRcheck-jsonschema --builtin-schema vendor.dependabot .github/dependabot.ymlpasses locally