Run typecheck on pre-commit to match CI - #24
Merged
Conversation
Pre-commit only ran prettier, so a TS type error would sail through locally and only get caught in CI. Add a typecheck command mirroring what CI already runs (npm run typecheck), gated to *.ts changes. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
CI and lefthook.yml are edited independently and drift silently -- a check added to one doesn't imply it's mirrored in the other, which is exactly what happened with the missing typecheck hook fixed in 763ae77. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
typecheckcommand tolefthook.yml'spre-commitblock, gated to*.tschanges, running the samenpm run typecheckCI already uses.Test plan
npm run typecheckpasses cleanly on its own.lefthookisn't installed in this worktree, but the new command mirrors the existingprettiercommand's shape.