add a persistent indicator to link targets#552
Open
michaelficarra wants to merge 2 commits intomainfrom
Open
Conversation
gibson042
approved these changes
Aug 31, 2023
Comment on lines
+778
to
+781
| :not(emu-clause, emu-annex, emu-table, emu-production):target { | ||
| text-decoration: wavy underline #FF9800; | ||
| text-decoration-skip-ink: none; | ||
| } |
Comment on lines
+772
to
+777
| /* add a more subtle persistent indicator to link targets */ | ||
| emu-clause:target, emu-annex:target, emu-table:target figure, emu-production:target { | ||
| border-left: 0.5em solid #FFC107; | ||
| padding-left: 1em; | ||
| margin-left: -1em; | ||
| } |
Member
There was a problem hiding this comment.
This makes the page content jump around... I think it would be better to take advantage of the visual gutter:
Suggested change
| /* add a more subtle persistent indicator to link targets */ | |
| emu-clause:target, emu-annex:target, emu-table:target figure, emu-production:target { | |
| border-left: 0.5em solid #FFC107; | |
| padding-left: 1em; | |
| margin-left: -1em; | |
| } | |
| /* add a more subtle persistent indicator to link targets */ | |
| emu-clause, emu-annex, emu-table figure, emu-production { | |
| position: relative; | |
| } | |
| emu-clause:target::before, emu-annex:target::before, emu-table:target figure::before, emu-production:target::before { | |
| position: absolute; | |
| top: 0; | |
| height: 100%; | |
| /* occupy some of #spec-container's 20px horizontal padding */ | |
| left: -18px; | |
| width: 9px; | |
| background: #FFC107; | |
| content: ''; | |
| } |
But also note that making sections position: relative necessitates generalizing Toolbox activation code in js/menu.js: #553
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Split from #441, which only gives a temporary highlight to link targets. This is a further enhancement to add a persistent indicator.