Fix/restart vpn state bug #730
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey dude, nice fixes. I noticed the tileservice bug ages ago and I'm glad it's finally got a solution. Hope you can sign off on your commits so they can merge them asap and get this fixed! |
Author
|
Thanks. It's not up to me to sign off on my commits. I submitted a PR for the Tailscale devs. They have to approve me PR and merge my change with master branch |
|
I meant sign off with DCO as it's been auto declined due to that. |
SegiH
force-pushed
the
fix/restart-vpn-state-bug
branch
from
b1685e2 to
3bdf669
Compare
Author
|
oh yea thanks for pointing that out. I think its fixed now |
jaydenbarta
approved these changes
Feb 8, 2026
…ing another VPN until Tailscale app is force closed because currentState=Ipn.State.Stopping on subsequent attempts to start TS Signed-off-by: Segi <segihovav@gmail.com>
SegiH
force-pushed
the
fix/restart-vpn-state-bug
branch
from
9126695 to
6ebc7bb
Compare
Signed-off-by: Segi <segihovav@gmail.com>
SegiH
force-pushed
the
fix/restart-vpn-state-bug
branch
from
4df1eb1 to
5457749
Compare
Signed-off-by: Segi <segihovav@gmail.com>
Signed-off-by: Segi <segihovav@gmail.com>
Signed-off-by: Segi <segihovav@gmail.com>
SegiH
force-pushed
the
fix/restart-vpn-state-bug
branch
from
16af475 to
05a3065
Compare
Author
|
is there anything else that I need to do to push this along ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates #17190
After enabling another VPN app in Android, you cannot enable the Tailscale radio toggle until you force stop it. The radio button will not enter the enabled state.
Steps to recreate this issue:
When tracing this issue, I found that at step 3, a break point at this point shows that the value of currentState is Ipn.State.Stopping not Ipn.State.Stopped as you might expect. When you enable Tailscale initially in step 1, currentState is Ipn.State.Stopped.
Enabling/Disabling Tailscale is done in 2 places in the Android app and this PR is to fix this issue in 2 places:
I check if the value of currentState is Ipn.State.Stopping and if it is, call stopVPN().
I also added a note to the README that its required to run
make libtailscaleto make the Tailscale AAR necessary to build the Android Tailscale app.