Close mobile navbar on link click in all hero-section headers#33
Closed
saimaneim wants to merge 1 commit intotailark:mainfrom
Closed
Close mobile navbar on link click in all hero-section headers#33saimaneim wants to merge 1 commit intotailark:mainfrom
saimaneim wants to merge 1 commit intotailark:mainfrom
Conversation
Contributor
|
@saimaneim is attempting to deploy a commit to the meschacirung's projects Team on Vercel. A member of the Team first needs to authorize it. |
Author
|
Sorry for not doing it in a different branch, I missed it, if you need it like this I can do it again |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
This PR improves the mobile navigation experience in the
hero-sectionblocks by ensuring the menu closes automatically when a link is clicked.What’s Changed
onClick={() => setMenuState(!menuState)}to all 9 header components within thehero-sectionblocks of the dusk-kit.Why
Previously, users had to manually close the navbar after navigating to a section.
This update provides a smoother and more intuitive mobile UX.