Skip to content

Comments

Feat/toml file config#6

Merged
dzdidi merged 3 commits intomainfrom
feat/toml-file-config
Feb 23, 2026
Merged

Feat/toml file config#6
dzdidi merged 3 commits intomainfrom
feat/toml-file-config

Conversation

@dzdidi
Copy link
Collaborator

@dzdidi dzdidi commented Feb 20, 2026

Blocked by / Based on #5

Pull request overview
This pull request migrates the configuration file format from JSON to TOML and adds two new delay configuration options for the probing feature. The migration improves configuration readability while maintaining backward compatibility through serde defaults.

Changes:

Migrated configuration format from config.json to config.toml throughout the codebase
Added probe_delay_sec and peer_delay_sec configuration fields to control timing between probes and peers
Implemented delay logic in the probing functionality to rate-limit probe requests

Signed-off-by: dzdidi <dzdidi@protonmail.com>
Signed-off-by: dzdidi <dzdidi@protonmail.com>
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request migrates the configuration file format from JSON to TOML and adds two new delay configuration options for the probing feature. The migration improves configuration readability while maintaining backward compatibility through serde defaults.

Changes:

  • Migrated configuration format from config.json to config.toml throughout the codebase
  • Added probe_delay_sec and peer_delay_sec configuration fields to control timing between probes and peers
  • Implemented delay logic in the probing functionality to rate-limit probe requests

Reviewed changes

Copilot reviewed 9 out of 10 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
src/config.rs Updated to parse TOML format instead of JSON; added two new delay configuration fields with default values (1s and 2s)
src/main.rs Implemented probe and peer delay logic in the probing loop; updated warning messages to reference config.toml
src/cli.rs Added probe_delay_sec and peer_delay_sec fields to ProbingConfig struct; updated comment to reference config.toml
src/args.rs Updated usage message to reference config.toml instead of config.json
Cargo.toml Added toml crate dependency version 0.8
Cargo.lock Lock file updates for toml crate and its dependencies (serde_spanned, toml_datetime, toml_edit, toml_write, winnow)
config.example.toml New TOML example configuration file with all fields including new delay settings
config.example.json Removed JSON example configuration file
README.md Updated documentation to reference TOML format throughout and replaced JSON example with TOML syntax
prober_config.json.example Added probe_delay_sec and peer_delay_sec fields to example

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Signed-off-by: dzdidi <dzdidi@protonmail.com>
Copy link

@ovitrif ovitrif left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👏🏻

Nice change, to adopt TOML 😎

@dzdidi dzdidi merged commit 0841cf7 into main Feb 23, 2026
@dzdidi dzdidi deleted the feat/toml-file-config branch February 23, 2026 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants