Merged
Conversation
Signed-off-by: dzdidi <dzdidi@protonmail.com>
Signed-off-by: dzdidi <dzdidi@protonmail.com>
Merged
There was a problem hiding this comment.
Pull request overview
This pull request migrates the configuration file format from JSON to TOML and adds two new delay configuration options for the probing feature. The migration improves configuration readability while maintaining backward compatibility through serde defaults.
Changes:
- Migrated configuration format from
config.jsontoconfig.tomlthroughout the codebase - Added
probe_delay_secandpeer_delay_secconfiguration fields to control timing between probes and peers - Implemented delay logic in the probing functionality to rate-limit probe requests
Reviewed changes
Copilot reviewed 9 out of 10 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/config.rs | Updated to parse TOML format instead of JSON; added two new delay configuration fields with default values (1s and 2s) |
| src/main.rs | Implemented probe and peer delay logic in the probing loop; updated warning messages to reference config.toml |
| src/cli.rs | Added probe_delay_sec and peer_delay_sec fields to ProbingConfig struct; updated comment to reference config.toml |
| src/args.rs | Updated usage message to reference config.toml instead of config.json |
| Cargo.toml | Added toml crate dependency version 0.8 |
| Cargo.lock | Lock file updates for toml crate and its dependencies (serde_spanned, toml_datetime, toml_edit, toml_write, winnow) |
| config.example.toml | New TOML example configuration file with all fields including new delay settings |
| config.example.json | Removed JSON example configuration file |
| README.md | Updated documentation to reference TOML format throughout and replaced JSON example with TOML syntax |
| prober_config.json.example | Added probe_delay_sec and peer_delay_sec fields to example |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Signed-off-by: dzdidi <dzdidi@protonmail.com>
ovitrif
approved these changes
Feb 23, 2026
ovitrif
left a comment
There was a problem hiding this comment.
LGTM 👏🏻
Nice change, to adopt TOML 😎
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Blocked by / Based on #5
Pull request overview
This pull request migrates the configuration file format from JSON to TOML and adds two new delay configuration options for the probing feature. The migration improves configuration readability while maintaining backward compatibility through serde defaults.
Changes:
Migrated configuration format from config.json to config.toml throughout the codebase
Added probe_delay_sec and peer_delay_sec configuration fields to control timing between probes and peers
Implemented delay logic in the probing functionality to rate-limit probe requests