Skip to content

add edit feature and thinking selection in nova chat#1018

Open
ved015 wants to merge 2 commits into
mainfrom
nova_chat
Open

add edit feature and thinking selection in nova chat#1018
ved015 wants to merge 2 commits into
mainfrom
nova_chat

Conversation

@ved015
Copy link
Copy Markdown
Member

@ved015 ved015 commented May 28, 2026

nova_chat2-1780069143861.mp4

@cloudflare-workers-and-pages
Copy link
Copy Markdown

cloudflare-workers-and-pages Bot commented May 28, 2026

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Preview URL Updated (UTC)
✅ Deployment successful!
View logs
supermemory-app f93b1f9 Commit Preview URL

Branch Preview URL
May 29 2026, 03:44 PM

@cloudflare-workers-and-pages
Copy link
Copy Markdown

cloudflare-workers-and-pages Bot commented May 28, 2026

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Updated (UTC)
✅ Deployment successful!
View logs
supermemory-mcp f93b1f9 May 29 2026, 03:42 PM

@graphite-app graphite-app Bot requested a review from Dhravya May 28, 2026 11:28
@claude
Copy link
Copy Markdown

claude Bot commented May 28, 2026

Claude finished @ved015's task in 1m 22s —— View job


Review Complete

  • Gather context from PR
  • Review diff for bugs, security issues, and logic errors
  • Check surrounding code for boundary issues
  • Post review summary

Overview: Adds message editing and reasoning effort selection (instant/thinking) to Nova chat.

Issues found: None — this looks good to ship.

The regeneration flow is well-designed with a two-phase approach: truncate messages first, then send via useEffect once React has processed the state update. The refs (truncateFromMessageIdRef, pendingRegenerationRef, pendingSendSettingsRef) correctly preserve transient state across re-renders, and the setTimeout(0) pattern ensures the truncate ref is available during request preparation but cleared afterward.

Key implementation details I verified:

  • The click-outside handler in ReasoningSelector properly cleans up its event listener on unmount
  • Input validation in submitEdit prevents empty submissions
  • Guard against sending during ongoing operations (status === "submitted" || status === "streaming")
  • No XSS concerns since message content is rendered as text nodes, not innerHTML
  • Model changes correctly reset reasoning effort to the default via getDefaultReasoningEffort()

Score: 9/10

Copy link
Copy Markdown

@claude claude Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overview: Adds message editing and reasoning effort selection (instant/thinking) to Nova chat.

Issues found: None — this looks good to ship.

The regeneration flow is well-designed with a two-phase approach: truncate messages first, then send via useEffect once React has processed the state update. The refs (truncateFromMessageIdRef, pendingRegenerationRef) correctly preserve transient state across re-renders, and the setTimeout(0) pattern ensures the truncate ref is available during request preparation but cleared afterward.

The click-outside handler in ReasoningSelector properly cleans up its event listener. Input validation in submitEdit prevents empty submissions. No XSS concerns since message content is rendered as text.

Score: 9/10

Co-authored-by: Cursor <cursoragent@cursor.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant