Skip to content

feat(zoom): zoom connector [needs testing]#1012

Open
sreedharsreeram wants to merge 2 commits into
mainfrom
feat/zoom-connector
Open

feat(zoom): zoom connector [needs testing]#1012
sreedharsreeram wants to merge 2 commits into
mainfrom
feat/zoom-connector

Conversation

@sreedharsreeram
Copy link
Copy Markdown
Member

No description provided.

@cloudflare-workers-and-pages
Copy link
Copy Markdown

cloudflare-workers-and-pages Bot commented May 27, 2026

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Updated (UTC)
✅ Deployment successful!
View logs
supermemory-mcp 11e615b May 27 2026, 02:30 AM

@cloudflare-workers-and-pages
Copy link
Copy Markdown

cloudflare-workers-and-pages Bot commented May 27, 2026

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Preview URL Updated (UTC)
✅ Deployment successful!
View logs
supermemory-app 11e615b Commit Preview URL

Branch Preview URL
May 27 2026, 02:30 AM

@claude
Copy link
Copy Markdown

claude Bot commented May 27, 2026

Claude finished @sreedharsreeram's task in 1m 46s —— View job


Reviewed PR #1012: feat(zoom): zoom connector

  • Fetching PR diff and analyzing changes
  • Reading changed files for context
  • Checking for bugs, security issues, and logic errors
  • Submitting review

Review Summary

Aspect Result
Score 9/10
Issues Found None

The PR correctly adds Zoom as a new connector option, following the established patterns for other connectors (Google Drive, Notion, OneDrive). The changes include:

  • Zoom added to ConnectorProvider type and CONNECTORS config
  • API schema updated with zoom provider enum
  • Display name and import provider type added
  • Zoom icon component added

The optional authLink/expiresIn fields are properly handled with existing null checks in the frontend.

Copy link
Copy Markdown

@claude claude Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overview: Adds Zoom as a new connector option in the web UI, wiring it into the add-document dropdown and settings page.

Issues found: None — this looks good to ship.

The changes follow the existing patterns for other connectors (Google Drive, Notion, OneDrive):

  • Zoom added to ConnectorProvider type and CONNECTORS config in both connection components
  • Provider added to API schema with correct enum updates
  • Display name and import provider type added to sync-utils
  • Icon component added using embedded base64 PNG

The authLink and expiresIn fields were made optional in the API schema, which is properly handled — the frontend already uses optional chaining (data?.authLink) before redirecting.

Score: 9/10

Minor note: The title says "[needs testing]" which is appropriate. Ensure the backend Zoom connection handler is in place and returns the expected response format before merging.

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
@sreedharsreeram sreedharsreeram removed the request for review from Dhravya May 27, 2026 02:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant