fix: only trigger after-user-created hook on account creation - #2656
Open
swithek wants to merge 1 commit into
Open
fix: only trigger after-user-created hook on account creation#2656swithek wants to merge 1 commit into
swithek wants to merge 1 commit into
Conversation
The external OAuth callback set createdUser unconditionally, so the hook also fired for AccountExists and LinkAccount, repeating side effects on every sign-in.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Bug fix.
What is the current behavior?
The external OAuth callback sets
createdUser = trueunconditionally, discarding themodels.AccountLinkingDecision. That branch handles every OAuth sign-in, soafter-user-createdalso fires forAccountExists(returning user) andLinkAccount(new identity on an existing user). Hook side effects therefore repeat on every sign-in, and since the hook's error propagates out of the callback, a hook that rejects a duplicate user breaks all OAuth sign-ins.What is the new behavior?
createdUseris gated ondecision == models.CreateAccount, matching the existing call sites intoken_oidc.go,web3.goandsamlacs.go.Additional context
Two regression tests in
ExternalTestSuitecover theAccountExistsandLinkAccountpaths.