feat: otp token hash with salt - #2650
Open
staaldraad wants to merge 1 commit into
Open
Conversation
Uses unique per instance salt when calculating otp hashes (otp, verify tokens, invite tokens). Falls back to unsalted hash lookup. Unsalted values will naturally expire according to otp validity period, the legacy lookup code can be safely removed then.
|
Found 24 test failures on Blacksmith runners: Failures
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Bug fix / feature
What is the current behavior?
otp hashes are generated in a predictable manner, making calculation of possible hash values possible.
What is the new behavior?
Uses unique per instance salt when calculating otp hashes (otp, verify tokens, invite tokens). Hash values remain deterministic per instance but not enumerable without knowing the secret salt value. Falls back to unsalted hash lookup. Unsalted values will naturally expire according to otp validity period, the legacy lookup code can be safely removed then.