feat: add pagination for oauth client list endpoint#2552
Open
cemalkilic wants to merge 3 commits into
Open
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| var clients []models.OAuthServerClient | ||
| if err := db.Q().Where("deleted_at is null").Order("created_at desc").All(&clients); err != nil { | ||
| q := db.Q().Where("deleted_at is null").Order("created_at desc") | ||
| if err := q.Paginate(int(pageParams.Page), int(pageParams.PerPage)).All(&clients); err != nil { // #nosec G115 |
| var clients []models.OAuthServerClient | ||
| if err := db.Q().Where("deleted_at is null").Order("created_at desc").All(&clients); err != nil { | ||
| q := db.Q().Where("deleted_at is null").Order("created_at desc") | ||
| if err := q.Paginate(int(pageParams.Page), int(pageParams.PerPage)).All(&clients); err != nil { // #nosec G115 |
fadymak
reviewed
May 29, 2026
Contributor
fadymak
left a comment
fadymak
left a comment
There was a problem hiding this comment.
Left a few minor comments. I'm a bit hesitant about proliferating the use of limit-offest-based pagination and including the total count given the performance on larger tables (the total count being the more concerning one).
For now, it looks like we only use pagination on GET /admin/users and GET /admin/audit — perhaps it's worth the inconsistency to start to move away from the total count (and potentially to cursor-based pagination)?
the bounds added in Paginate() function already tracks them
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Feature
What is the current behavior?
Resolves the TODO in OAuthServerClientListm now mirrors the
/admin/userspagination behaviour (page/per_page query params,LinkandX-Total-Countresponse headers).Moves the paginate/addPaginationHeaders helpers into
internal/api/sharedso both the api and oauthserver packages can use them without a circular import.