feat: support allow_expired query parameter for JWT validation#2257
Closed
feat: support allow_expired query parameter for JWT validation#2257
Conversation
77ba7de to
3b35ecc
Compare
Contributor
|
@mandarini Are you still wanting to implement this? If you are we will need a greater refactor here because |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds support for
allow_expired=truequery parameter to allow decoding expired JWTs for legitimate use cases (debugging, audit logs, displaying user info after expiration).Fixes: #2256
Changes
parseJWTClaims()ininternal/api/auth.goto check forallow_expiredquery parameterallow_expired=true, JWT parser skips claims validation (including expiration check)Security Considerations
Testing
Tested with expired JWTs: