✨(frontend) Start the presenter from a block - #2485
Conversation
|
Size Change: +444 B (+0.01%) Total Size: 4.36 MB 📦 View Changed
|
0a311b8 to
f1a8ad9
Compare
f1a8ad9 to
71bfaec
Compare
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (6)
WalkthroughAdds a custom BlockNote side menu with deletion, presentation, color, and table header actions. Adds recursive block-to-content-slide mapping with fallback handling for empty groups, dividers, nested blocks, and missing IDs. Wires the custom menu into the editor and adds end-to-end coverage for presenting from “Slide two.” Estimated code review effort: 3 (Moderate) | ~20 minutes Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches 💡 1🛠️ Fix failing CI checks 💡
📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 3
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In
`@src/frontend/apps/impress/src/features/docs/doc-editor/components/BlockNoteSideMenu.tsx`:
- Line 54: Update the side-menu label in BlockNoteSideMenu to use the
translation key for “Present from here” instead of “Present”, matching the
agreed wording and preserving the existing translation mechanism.
- Around line 67-79: Replace the hand-rolled Components.Generic.Menu.Dropdown
wrapper in the side-menu component with the public DragHandleMenu component
imported from `@blocknote/react`, preserving the existing RemoveBlockItem,
PresentBlockItem, BlockColorsItem, TableRowHeaderItem, and TableColumnHeaderItem
children and their order.
- Line 82: Update DocsDragHandleMenu to use the exported DragHandleMenu
component as its wrapper instead of Components.Generic.Menu.Dropdown, and type
the menu with DragHandleMenu’s expected props. Preserve the existing menu items
while ensuring DocsSideMenu continues passing the corrected component through
dragHandleMenu.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository UI
Review profile: ASSERTIVE
Plan: Pro Plus
Run ID: ca04b917-50c4-44e1-879b-39a840ce94f4
📒 Files selected for processing (5)
src/frontend/apps/e2e/__tests__/app-impress/presenter-mode.spec.tssrc/frontend/apps/impress/src/features/docs/doc-editor/components/BlockNoteEditor.tsxsrc/frontend/apps/impress/src/features/docs/doc-editor/components/BlockNoteSideMenu.tsxsrc/frontend/apps/impress/src/features/docs/doc-presenter/__tests__/useSlides.spec.tssrc/frontend/apps/impress/src/features/docs/doc-presenter/hooks/useSlides.ts
d0a091e to
0333980
Compare
AntoLC
left a comment
There was a problem hiding this comment.
Maybe worth to switch to DragHandleMenu, I let you judge:
#2485 (comment)
0333980 to
23f1c1d
Compare
Add a "Present" item to the block side menu that opens the presenter on the slide containing that block. Map any block id (incl. nested or divider ids) to its rendered content slide. Closes #2470
Exercise block-to-slide mapping and the editor side-menu action. Keep coverage scoped to starting the presenter from a block.
23f1c1d to
b956be1
Compare
Purpose
Refs #2466
Closes #2470