build(deps): remove manual set-up of abseil-cpp#150
Open
ingomueller-net wants to merge 2 commits intosubstrait-io:mainfrom
Open
build(deps): remove manual set-up of abseil-cpp#150ingomueller-net wants to merge 2 commits intosubstrait-io:mainfrom
ingomueller-net wants to merge 2 commits intosubstrait-io:mainfrom
Conversation
This PR refactors the CMake logic that finds or fetches the GTest/googletest dependency. It follows the same pattern applied by substrait-io#138 for the protobuf library. The PR also removes a redundant logic of finding/fetching that dependency, which previously existed twice. Signed-off-by: Ingo Müller <ingomueller@google.com>
This PR removes the `abseil-cpp` git submodule and all related CMake logic because this code is not compatiable with pre-abseil versions of protobuf, so abseil is provided with protobuf always. Signed-off-by: Ingo Müller <ingomueller@google.com>
Contributor
Author
|
I tried in some CI jobs for #148 to compile the project with Protobuf v21 but that failed. CI the logs of that job (linked in comments). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is stacked on #140.
This PR removes the
abseil-cppgit submodule and all related CMake logic because this code is not compatiable with pre-abseil versions of protobuf, so abseil is provided with protobuf always.