build(clang-tidy): add project prefix to clang tidy variable name#146
Open
ingomueller-net wants to merge 1 commit intosubstrait-io:mainfrom
Open
build(clang-tidy): add project prefix to clang tidy variable name#146ingomueller-net wants to merge 1 commit intosubstrait-io:mainfrom
ingomueller-net wants to merge 1 commit intosubstrait-io:mainfrom
Conversation
This PR fixes a variable name clash between this project and potential downstream projects. If they both use the variable `CLANG_TIDY_COMMAND` to enable or disable `clang-tidy`, it is impossible to activate `clang-tidy` for the downstream project and deactivate it for this project. See substrait-io/substrait-mlir-contrib#204. Signed-off-by: Ingo Müller <ingomueller@google.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a variable name clash between this project and potential downstream projects. If they both use the variable
CLANG_TIDY_COMMANDto enable or disableclang-tidy, it is impossible to activateclang-tidyfor the downstream project and deactivate it for this project. See substrait-io/substrait-mlir-contrib#204.