build(deps): refactor CMake files for finding Protobuf#138
Merged
ingomueller-net merged 1 commit intosubstrait-io:mainfrom Mar 26, 2026
Merged
Conversation
ingomueller-net
force-pushed
the
cmake-revamp-protobuf
branch
from
3eb9312 to
dbe1d9b
Compare
ingomueller-net
added a commit
to ingomueller-net/substrait-cpp
that referenced
this pull request
Mar 26, 2026
This PR refactors the CMake logic that finds or fetches the GTest/googletest dependency. It follows the same pattern applied by substrait-io#138 for the protobuf library. The PR also removes a redundant logic of finding/fetching that dependency, which previously existed twice. Signed-off-by: Ingo Müller <ingomueller@google.com>
ingomueller-net
changed the title
EpsilonPrime
approved these changes
Mar 26, 2026
auto-merge was automatically disabled
March 26, 2026 16:40
Pull Request is not mergeable
ingomueller-net
force-pushed
the
cmake-revamp-protobuf
branch
from
dbe1d9b to
de0f074
Compare
This PR refactors the CMake logic that finds or fetches the protobuf dependency. This consists of the following individual changes: * Move the fetching of the `googletest` dependency from `protobuf.cmake` to `gtest.cmake` because it is unrelated. * Introduce options that allow to disable the usage of `find_package` and `FetchContent` respectively in order to give downstream projects control on how the dependency is provided. * Introduce options to enable or disable config mode for `find_package` and the git tag used by `FetchContent` for the same reason. Signed-off-by: Ingo Müller <ingomueller@google.com>
ingomueller-net
force-pushed
the
cmake-revamp-protobuf
branch
from
de0f074 to
283f0a2
Compare
ingomueller-net
added a commit
to ingomueller-net/substrait-cpp
that referenced
this pull request
Mar 26, 2026
This PR refactors the CMake logic that finds or fetches the GTest/googletest dependency. It follows the same pattern applied by substrait-io#138 for the protobuf library. The PR also removes a redundant logic of finding/fetching that dependency, which previously existed twice. Signed-off-by: Ingo Müller <ingomueller@google.com>
ingomueller-net
added a commit
to ingomueller-net/substrait-cpp
that referenced
this pull request
Mar 27, 2026
This PR refactors the CMake logic that finds or fetches the GTest/googletest dependency. It follows the same pattern applied by substrait-io#138 for the protobuf library. The PR also removes a redundant logic of finding/fetching that dependency, which previously existed twice. Signed-off-by: Ingo Müller <ingomueller@google.com>
ingomueller-net
added a commit
to ingomueller-net/substrait-cpp
that referenced
this pull request
Mar 30, 2026
This PR refactors the CMake logic that finds or fetches the GTest/googletest dependency. It follows the same pattern applied by substrait-io#138 for the protobuf library. The PR also removes a redundant logic of finding/fetching that dependency, which previously existed twice. Signed-off-by: Ingo Müller <ingomueller@google.com>
ingomueller-net
added a commit
to ingomueller-net/substrait-cpp
that referenced
this pull request
Mar 31, 2026
This PR refactors the CMake logic that finds or fetches the GTest/googletest dependency. It follows the same pattern applied by substrait-io#138 for the protobuf library. The PR also removes a redundant logic of finding/fetching that dependency, which previously existed twice. Signed-off-by: Ingo Müller <ingomueller@google.com>
ingomueller-net
added a commit
to ingomueller-net/substrait-cpp
that referenced
this pull request
Mar 31, 2026
This PR refactors the CMake logic that finds or fetches the abseil-cpp dependency. It follows the same pattern applied by substrait-io#138 for the protobuf library. Signed-off-by: Ingo Müller <ingomueller@google.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR refactors the CMake logic that finds or fetches the protobuf dependency. This consists of the following individual changes:
googletestdependency fromprotobuf.cmaketogtest.cmakebecause it is unrelated.find_packageandFetchContentrespectively in order to give downstream projects control on how the dependency is provided.find_packageand the git tag used byFetchContentfor the same reason.