Python reader for FWH binary surface data#2761
Closed
riddhi1228 wants to merge 2 commits intosu2code:developfrom
Closed
Python reader for FWH binary surface data#2761riddhi1228 wants to merge 2 commits intosu2code:developfrom
riddhi1228 wants to merge 2 commits intosu2code:developfrom
Conversation
…weepLib.py string.join() was removed in Python 3. Replace with the equivalent ''.join() syntax. Also removes the now-unused 'import string' statement. Fixes AttributeError: module 'string' has no attribute 'join' when running polar sweep analysis on Python 3.
Member
|
Please setup your AI tool properly and respect the PR description template |
Author
|
Sorry about that — I'll reopen using the proper PR description template. Thanks for the pointer. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
SU2.io.fwh.FWHData, a pure-Python reader for the FWH binary surface data format. The committed reference fileTestCases/unsteady/square_cylinder/fwh_bin.dathad no corresponding Python reader in the repository. This PR closes that gap.Binary format (decoded from reference file)
Verified against
fwh_bin.dat:n_t=50,n_pts=200, pressure range 825–1104 Pa, temporal RMS max ≈74 Pa — physically consistent with Ma=0.1 RANS flow past a square cylinder.API
Testing
17 pytest tests in
SU2_PY/tests/test_fwh_reader.py:Notes
SU2_PY/cc @pcarruscag