Skip to content

Fix: Resolved useTitle eslint warnings#2707

Open
janifkader wants to merge 1 commit into
streamich:masterfrom
janifkader:fix/useTitle-eslint
Open

Fix: Resolved useTitle eslint warnings#2707
janifkader wants to merge 1 commit into
streamich:masterfrom
janifkader:fix/useTitle-eslint

Conversation

@janifkader

Copy link
Copy Markdown

Description

Fixes ESLint warnings in useTitle.ts as part of #947. Changes include copying prevTitleRef.current to a local variable for use in the effect and added options to the dependency array.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as before)

Checklist

  • Read the Contributing Guide
  • Perform a code self-review
  • Comment the code, particularly in hard-to-understand areas
  • Add documentation
  • Add hook's story at Storybook
  • Cover changes with tests
  • Ensure the test suite passes (yarn test)
  • Provide 100% tests coverage
  • Make sure code lints (yarn lint). Fix it with yarn lint:fix in case of failure.
  • Make sure types are fine (yarn lint:types).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant