Skip to content

Add an open-link button to skill cards and retire generic Soroban wording - #94

Merged
kaankacar merged 2 commits into
mainfrom
issue-agent/27-open-link-and-branding
Aug 13, 2026
Merged

Add an open-link button to skill cards and retire generic Soroban wording#94
kaankacar merged 2 commits into
mainfrom
issue-agent/27-open-link-and-branding

Conversation

@kaankacar

Copy link
Copy Markdown
Contributor

🤖 Automated message from Kaan's Automated Triage Bot.

Refs #27 (deliberately not "Closes" — this picks off two items from James's list, the rest are editorial calls I'd rather leave to a human).

The first commit adds the open-link button he asked for: each skill card's copy pill now has an anchor beside it pointing at the same markdown URL, target="_blank". Ecosystem cards don't get one, because their copy value is already the URL the card header links to and a second chip would send you to the same place twice. One caveat worth knowing before merge: GitHub Pages serves those files as text/markdown, so whether a browser renders the file inline or offers a download is up to the browser, and the site can't set response headers to influence that.

The second commit is the "Soroban" pass. Generic prose about Soroban contracts, transactions, and tokens now says Stellar smart contracts, matching what smart-contracts/SKILL.md already states about the retired platform name. Proper nouns stay put: soroban-sdk, SorobanArbitrary, the SEP-41 and CAP-46 titles, project names like Scout Soroban and Soroban Playground, and the frontmatter descriptions that keep "Soroban" as a trigger word for users who still call it that. Stellar's own docs still use the name in those senses, so a blanket rename would have made things less accurate, not more. The site README also documented category: "Soroban", which isn't a FilterType value any more and would fail tsc if anyone copied it.

Note on verification: I could not run pnpm lint, lint:ts, or build in my sandbox (no pnpm available), so I'm relying on the preview workflow to check them. Please don't merge until it's green, and the preview URL is the fastest way to eyeball the new chip.

The pill hands you the markdown URL but there was no way to just look at
the file. Skill cards now carry an anchor to the same URL the pill copies.
Ecosystem cards are left alone: their copy value is already the URL the
card header links to, so a second chip would point at one destination
twice.
The platform name is retired, and smart-contracts/SKILL.md already says so.
This applies the same wording to the places that still described generic
contracts, transactions, and tokens as Soroban ones. Proper nouns stay:
soroban-sdk, SorobanArbitrary, the SEP-41/CAP-46 titles, project names like
Scout Soroban, and the frontmatter descriptions that keep Soroban as a
trigger word for people who still call it that. Also fixes the site README,
which showed a category value that is no longer in FilterType.
Copilot AI balanced review requested due to automatic review settings August 13, 2026 18:05
@github-actions

github-actions Bot commented Aug 13, 2026

Copy link
Copy Markdown
PR Preview Action v1.8.1
Preview removed because the pull request was closed.
2026-08-13 18:14 UTC

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds direct markdown links to first-party skill cards and modernizes generic Soroban terminology.

Changes:

  • Adds an accessible new-tab link beside each first-party skill copy button.
  • Replaces generic Soroban wording with Stellar smart contract terminology.
  • Corrects the documented skill category example.

Reviewed changes

Copilot reviewed 9 out of 9 changed files in this pull request and generated no comments.

Show a summary per file
File Description
skills/standards/SKILL.md Updates K2 terminology.
skills/smart-contracts/development.md Modernizes transaction terminology.
skills/dapp/SKILL.md Updates contract invocation wording.
skills/cross-chain/SKILL.md Modernizes cross-chain contract terminology.
skills/cross-chain/cctp.md Updates CCTP contract and transaction wording.
skills/cross-chain/axelar.md Updates Axelar contract and token terminology.
site/src/app/styles.scss Styles the copy-and-open control row.
site/src/app/_components/SkillCard.tsx Adds the first-party markdown open-link button.
site/README.md Corrects the FilterType category example.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@kaankacar

Copy link
Copy Markdown
Contributor Author

🤖 Automated message from Kaan's Automated Triage Bot.

Picked this up — assessing whether I can ship an airtight fix.

@kaankacar
kaankacar merged commit 17ab14e into main Aug 13, 2026
7 checks passed
@kaankacar
kaankacar deleted the issue-agent/27-open-link-and-branding branch August 13, 2026 18:13
@kaankacar

Copy link
Copy Markdown
Contributor Author

🤖 Automated message from Kaan's Automated Triage Bot.

Merged. The verification this PR deferred is now in: the preview workflow ran pnpm install --frozen-lockfile, lint, lint:ts, and build against 0e21ff5 — the exact head reviewed — and all four passed, so the note asking to hold for green is satisfied. Copilot reviewed all 9 files and raised nothing.

I also checked the two things worth checking by hand: the chip's copyValue !== sourceUrl guard does hide it on ecosystem cards (page.tsx passes the same value for both), and every remaining "Soroban" in skills/ is a proper noun — SDK and tool names, SEP-41/CAP-46 titles, project names, and the frontmatter trigger words, which are byte-identical.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants