Apply inclusion fee and resource fee to simulated tx correctly #2355
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
leighmcculloch
left a comment
leighmcculloch
left a comment
There was a problem hiding this comment.
👋🏻 Little concerned we're working around and covering a bug, take a look inline.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a bug in how transaction fees are calculated when simulating and assembling Stellar transactions. Previously, the code was overriding the inclusion fee instead of properly adding it to the resource fee.
Changes:
- Changed
resource_feeparameter type fromu64toi64to match XDR spec, with validation to ensure non-negative values - Fixed fee calculation to sum inclusion fee and resource fee instead of taking the maximum
- Applied user-specified resource fee to the transaction_data structure when provided
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| cmd/soroban-cli/src/resources.rs | Changed resource_fee type to i64 with range validation, matching XDR specification |
| cmd/soroban-cli/src/assembled.rs | Fixed fee calculation logic, removed DEFAULT_TRANSACTION_FEES constant, properly applies resource_fee to transaction_data, added comprehensive tests for edge cases |
leighmcculloch
approved these changes
Jan 19, 2026
Co-authored-by: Leigh <[email protected]>
Co-authored-by: Copilot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
We were overriding inclusion fee and not applying resource fee inputs to the simulated transaction