Skip to content

Conversation

@fnando
Copy link
Member

@fnando fnando commented Dec 16, 2025

What

[TODO: Short statement about what is changing.]

Why

[TODO: Why this change is being made. Include any context required to understand the why.]

Known limitations

[TODO or N/A]

@socket-security
Copy link

socket-security bot commented Dec 16, 2025

@socket-security
Copy link

socket-security bot commented Jan 12, 2026

Warning

Review the following alerts detected in dependencies.

According to your organization's Security Policy, it is recommended to resolve "Warn" alerts. Learn more about Socket for GitHub.

Action Severity Alert  (click "▶" to expand/collapse)
Warn High
License policy violation: cargo visibility under Apache-2.0 AND MIT AND Zlib

Location: Package overview

From: ?cargo/soroban-sdk@25.0.0-rc.2cargo/visibility@0.1.1

ℹ Read more on: This package | This alert | What is a license policy violation?

Next steps: Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support@socket.dev.

Suggestion: Find a package that does not violate your license policy or adjust your policy to allow this package's license.

Mark the package as acceptable risk. To ignore this alert only in this pull request, reply with the comment @SocketSecurity ignore cargo/visibility@0.1.1. You can also ignore all packages with @SocketSecurity ignore-all. To ignore an alert for all future pull requests, use Socket's Dashboard to change the triage state of this alert.

View full report

@mootz12 mootz12 marked this pull request as ready for review January 21, 2026 14:31
Copilot AI review requested due to automatic review settings January 21, 2026 14:31
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the Stellar CLI dependencies from protocol 23 to protocol 25, updating multiple core dependencies including stellar-xdr, soroban-sdk, and related libraries. The update includes a code change to adapt to a breaking API change in the soroban-spec library.

Changes:

  • Updated stellar-xdr from 23.0.0 to 25.0.0
  • Updated multiple soroban dependencies to version 25.0.0-rc.2 or 25.0.1
  • Adapted code to handle API change where from_wasm now returns a Vec requiring .as_slice() call
  • Added new transitive dependencies (ark-bn254, ctor updates, dtor, visibility)

Reviewed changes

Copilot reviewed 2 out of 3 changed files in this pull request and generated 3 comments.

File Description
Cargo.toml Updates workspace dependencies to protocol 25 versions; uses git branch references for soroban-spec and soroban-spec-rust instead of published versions
Cargo.lock Reflects dependency version updates and adds new transitive dependencies; includes dual versions of soroban-spec (23.3.0 from git, 25.0.0-rc.2 from crates.io)
cmd/crates/soroban-spec-typescript/src/lib.rs Adapts to API change by adding .as_slice() call when passing spec to generate function

@mootz12 mootz12 merged commit 6fb4feb into main Jan 21, 2026
29 of 30 checks passed
@mootz12 mootz12 deleted the p25 branch January 21, 2026 17:14
@github-project-automation github-project-automation bot moved this from Backlog (Not Ready) to Done in DevX Jan 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants