-
Notifications
You must be signed in to change notification settings - Fork 124
Update to protocol 25. #2331
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to protocol 25. #2331
Conversation
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
|
Warning Review the following alerts detected in dependencies. According to your organization's Security Policy, it is recommended to resolve "Warn" alerts. Learn more about Socket for GitHub.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR updates the Stellar CLI dependencies from protocol 23 to protocol 25, updating multiple core dependencies including stellar-xdr, soroban-sdk, and related libraries. The update includes a code change to adapt to a breaking API change in the soroban-spec library.
Changes:
- Updated stellar-xdr from 23.0.0 to 25.0.0
- Updated multiple soroban dependencies to version 25.0.0-rc.2 or 25.0.1
- Adapted code to handle API change where
from_wasmnow returns a Vec requiring.as_slice()call - Added new transitive dependencies (ark-bn254, ctor updates, dtor, visibility)
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| Cargo.toml | Updates workspace dependencies to protocol 25 versions; uses git branch references for soroban-spec and soroban-spec-rust instead of published versions |
| Cargo.lock | Reflects dependency version updates and adds new transitive dependencies; includes dual versions of soroban-spec (23.3.0 from git, 25.0.0-rc.2 from crates.io) |
| cmd/crates/soroban-spec-typescript/src/lib.rs | Adapts to API change by adding .as_slice() call when passing spec to generate function |
What
[TODO: Short statement about what is changing.]
Why
[TODO: Why this change is being made. Include any context required to understand the why.]
Known limitations
[TODO or N/A]