Repository navigation
Conversation
|
🦞👀 Pull request received. I will update this pull request when review starts. ClawSweeper review completeClawSweeper finished reviewing this revision. The review result is being finalized. |
|
Codex review: blocked before merge. Reviewed September 24, 2026, 1:56 AM ET / 05:56 UTC. ClawSweeper reviewWhat this changesAdds medium and large Accounts widgets that show one provider’s active account beside a browsable saved account, plus snapshot compatibility, tests, screenshots, and widget documentation. Merge readiness⛔ Blocked before merge - 2 items remain Current main and v0.65.0 have no multi-account overview widget, so this PR remains useful. The reviewed branch has no clear blocking code defect, and the supplied native images show the new tiles. The remaining blocker is the repository owner’s sign-off on adding a widget type. Priority: P3 Review scores
Verification
How this fits togetherThe CodexBar app publishes provider and account usage into a shared snapshot read by its macOS widgets. The new widget filters that snapshot by provider and uses a saved display selection to choose the companion account. flowchart LR
A[Provider account usage] --> B[Shared widget snapshot]
B --> C[Provider account filter]
D[Saved companion choice] --> E[Account pager]
C --> E
E --> F[Medium or large Accounts tile]
Decision needed
Why: VISION.md reserves new features and meaningful maintenance complexity for sign-off, and the existing issue explicitly left the widget form undecided. Before merge
Agent review detailsSecurityNone. Review metrics
Root-cause clusterRelationship: Members:
Proposal only: this assessment does not dispatch repair, suppress jobs, mutate sibling items, close, or merge anything. Technical reviewBest possible solution: If the owner approves the feature, land the separate opt-in widget while retaining existing widget configurations and the legacy snapshot decode path. Do we have a high-confidence way to reproduce the issue? Not applicable: this is a new widget capability. Current main and v0.65.0 register no Accounts overview widget. Is this the best way to solve the issue? Yes, subject to product sign-off: a separate opt-in widget reuses existing account snapshots and leaves established widgets available. AGENTS.md: found and applied where relevant. Codex review notes: model internal, reasoning medium; reviewed against fec33b3bc619. LabelsLabel changes:
Label justifications:
EvidenceWhat I checked:
Likely related people:
Rating scale
Overall follows the weaker of proof and patch quality. Workflow
|
|
Thanks @aledeul. Keeping this open for a maintainer version. At |
|
Thanks @aledeul for the implementation, tests, and widget images. The snapshot reuse and backward-compatible active marker are useful. I recommend closing this version because paging persistence, combined provider history, and changes to existing Account Usage widgets exceed the smaller quota-only overview we want to ship. The pager also covers only published accounts: the app caps that set at six, so additional configured accounts are absent from its count. We’ll keep #3144 open to settle the smaller overview’s visible-account and overflow behavior. No contributor revision is requested; adopted work will retain your credit. |
Existing Account Usage widgets pin a single account, and the snapshot writer published at most six accounts per provider without saying how many were left out. The new CodexBar Accounts widget shows a quota-only overview: up to four accounts on medium and eight on large, sorted by lowest remaining general quota with stable ties, unavailable accounts last, and a single "+N more" row that counts both the widget cutoff and accounts beyond the six-account snapshot cap (published as anonymous overflow counts). No paging, no combined history; refresh opt-in, ownership guards and privacy labels are unchanged. Reuses the widget configuration and provider-safe account filtering explored in #3938. Fixes #3144 Co-authored-by: Adrien Ledeul <adrien.ledeul@cern.ch> Thanks @nicosuave for the request and @aledeul for #3938!
|
Thanks @aledeul for the implementation and visual exploration. #4400 (now merged as 2b58ada) adopts the reusable widget configuration and provider-safe account filtering, with your co-author credit, in the smaller approved quota-only overview. It adds the four/eight row limits and a count for accounts beyond the six-account snapshot cap. Paging, combined history, and changes to existing Account Usage tiles remain outside this version. This PR is already closed; no contributor revision is requested. |
Add an opt-in medium/large CodexBar Accounts widget that keeps the active account visible while browsing other saved accounts for the same provider. For example, an active account saved sixth still appears first, with one inactive account alongside it. The pager changes the displayed account only; it does not switch credentials. Accounts widgets for a provider share their remembered companion selection.
The widget reuses the existing Usage layout. This also carries the remaining Account Usage header/spacing refinements from #3921. Quotas, extra usage, and Today/30d rows stay account-specific. When an account has no attributed history, large tiles can show the provider's chart labelled Combined local [provider] history; account-owned history takes precedence. Existing account snapshots remain readable when the new active marker is absent.
This is the feature-only follow-up to #3921, based on current main. The Claude refresh and ownership fix adopted in #3930 / 0d84897 is already in the base and has no diff here. The existing single-account widget is retained.
Refs #3144. Maintainer decision requested: approve a separate opt-in Accounts widget under
VISION.md. This PR does not assume that product sign-off has been granted.Validation
DEVELOPER_DIR=/Applications/Xcode.app/Contents/Developer CODEXBAR_TEST_GROUP_SIZE=24 CODEXBAR_TEST_RETRY_NON_TIMEOUT_FAILURES=0 make test: all 1,373 selections / 67 groups passed on the first attempt, with no failures, timeouts, or retries.DEVELOPER_DIR=/Applications/Xcode.app/Contents/Developer make check: zero violations in 2,620 files.CODEXBAR_ACCOUNT_RENDER_DIRwith Keychain access suppressed and test file isolation enabled.git diff --checkpassed. The widget implementation matches the previously reviewed feature branch; the already-landed Claude refresh/snapshot implementation and its tests have no diff against main.Visual evidence
The native desktop screenshots below use anonymized Account 1/2 labels and the desktop's automatic monochrome appearance. They were captured for #3921; the widget implementation is unchanged in this extraction. Synthetic production-view renders were regenerated on this branch for all eight widget types and all 16 supported type/size combinations, in light/dark appearances with two/three quota windows (64 images). Small proof is a synthetic SwiftUI render with simulated widget margins, not a desktop WidgetKit capture.