Skip to content

Conversation

@hrshya
Copy link
Contributor

@hrshya hrshya commented Jan 25, 2026

Resolves none .

Description

What is the purpose of this pull request?

This pull request:

  • Refactors random number generation in JS benchmarks for the stats/base/dists/normal/ packages.
  • Replaces uniform() from @stdlib/random/array/uniform for cleaner and more consistent code.
  • Moves the random number generation outside the benchmarking loops.
  • Refactors to use string interpolation.

Related Issues

Does this pull request have any related issues?

This pull request:

  • resolves no related issues.

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.


@stdlib-js/reviewers

@stdlib-bot stdlib-bot added Statistics Issue or pull request related to statistical functionality. Needs Review A pull request which needs code review. labels Jan 25, 2026
@hrshya hrshya added the Benchmarks Pull requests adding or improving benchmarks for measuring performance. label Jan 25, 2026
@stdlib-bot
Copy link
Contributor

stdlib-bot commented Jan 25, 2026

Coverage Report

Package Statements Branches Functions Lines
stats/base/dists/normal/cdf $\color{green}299/299$
$\color{green}+0.00%$
$\color{green}25/25$
$\color{green}+0.00%$
$\color{green}4/4$
$\color{green}+0.00%$
$\color{green}299/299$
$\color{green}+0.00%$
stats/base/dists/normal/ctor $\color{green}487/487$
$\color{green}+0.00%$
$\color{green}36/36$
$\color{green}+0.00%$
$\color{green}19/19$
$\color{green}+0.00%$
$\color{green}487/487$
$\color{green}+0.00%$
stats/base/dists/normal/entropy $\color{green}178/178$
$\color{green}+0.00%$
$\color{green}9/9$
$\color{green}+0.00%$
$\color{green}2/2$
$\color{green}+0.00%$
$\color{green}178/178$
$\color{green}+0.00%$
stats/base/dists/normal/kurtosis $\color{green}175/175$
$\color{green}+0.00%$
$\color{green}9/9$
$\color{green}+0.00%$
$\color{green}2/2$
$\color{green}+0.00%$
$\color{green}175/175$
$\color{green}+0.00%$
stats/base/dists/normal/logcdf $\color{green}325/325$
$\color{green}+0.00%$
$\color{green}27/27$
$\color{green}+0.00%$
$\color{green}4/4$
$\color{green}+0.00%$
$\color{green}325/325$
$\color{green}+0.00%$
stats/base/dists/normal/logpdf $\color{green}312/312$
$\color{green}+0.00%$
$\color{green}23/23$
$\color{green}+0.00%$
$\color{green}4/4$
$\color{green}+0.00%$
$\color{green}312/312$
$\color{green}+0.00%$
stats/base/dists/normal/mean $\color{green}175/175$
$\color{green}+0.00%$
$\color{green}9/9$
$\color{green}+0.00%$
$\color{green}2/2$
$\color{green}+0.00%$
$\color{green}175/175$
$\color{green}+0.00%$
stats/base/dists/normal/median $\color{green}175/175$
$\color{green}+0.00%$
$\color{green}9/9$
$\color{green}+0.00%$
$\color{green}2/2$
$\color{green}+0.00%$
$\color{green}175/175$
$\color{green}+0.00%$
stats/base/dists/normal/mgf $\color{green}293/293$
$\color{green}+0.00%$
$\color{green}19/19$
$\color{green}+0.00%$
$\color{green}4/4$
$\color{green}+0.00%$
$\color{green}293/293$
$\color{green}+0.00%$
stats/base/dists/normal/mode $\color{green}175/175$
$\color{green}+0.00%$
$\color{green}9/9$
$\color{green}+0.00%$
$\color{green}2/2$
$\color{green}+0.00%$
$\color{green}175/175$
$\color{green}+0.00%$
stats/base/dists/normal/pdf $\color{green}316/316$
$\color{green}+0.00%$
$\color{green}25/25$
$\color{green}+0.00%$
$\color{green}4/4$
$\color{green}+0.00%$
$\color{green}316/316$
$\color{green}+0.00%$
stats/base/dists/normal/quantile $\color{green}306/306$
$\color{green}+0.00%$
$\color{green}27/27$
$\color{green}+0.00%$
$\color{green}4/4$
$\color{green}+0.00%$
$\color{green}306/306$
$\color{green}+0.00%$
stats/base/dists/normal/skewness $\color{green}175/175$
$\color{green}+0.00%$
$\color{green}9/9$
$\color{green}+0.00%$
$\color{green}2/2$
$\color{green}+0.00%$
$\color{green}175/175$
$\color{green}+0.00%$
stats/base/dists/normal/stdev $\color{green}175/175$
$\color{green}+0.00%$
$\color{green}9/9$
$\color{green}+0.00%$
$\color{green}2/2$
$\color{green}+0.00%$
$\color{green}175/175$
$\color{green}+0.00%$
stats/base/dists/normal/variance $\color{green}175/175$
$\color{green}+0.00%$
$\color{green}9/9$
$\color{green}+0.00%$
$\color{green}2/2$
$\color{green}+0.00%$
$\color{green}175/175$
$\color{green}+0.00%$

The above coverage report was generated for the changes in this PR.

@kgryte kgryte added difficulty: 1 Low degree of difficulty. Should be straightforward to implement and/or resolve. and removed Needs Review A pull request which needs code review. labels Jan 26, 2026
@kgryte kgryte merged commit 53c6e6c into stdlib-js:develop Jan 26, 2026
29 checks passed
@hrshya hrshya deleted the bench/normal branch January 26, 2026 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Benchmarks Pull requests adding or improving benchmarks for measuring performance. difficulty: 1 Low degree of difficulty. Should be straightforward to implement and/or resolve. review: 4 Statistics Issue or pull request related to statistical functionality.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants