Skip to content

build(workflows): don't fail process_metadata on non-YAML comments #13860

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Planeshifter wants to merge 1 commit into
base: develop
Choose a base branch
from
Draft

build(workflows): don't fail process_metadata on non-YAML comments #13860

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions .github/workflows/process_metadata.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,11 +92,14 @@ jobs:
# Pin action to full length commit SHA
uses: stdlib-js/metadata-action@3ccf68f24c51ae23470319e8e5619d539df8212b # v3.0.0

# Continue with subsequent steps even when this step fails (e.g., due to a non-YAML comment body) in order to "pass" the job and not trigger failure e-mails/notifications:
continue-on-error: true

# Check the metadata for directives to send tweets:
- name: 'Send tweets'

# Only run this step if a user has write access:
if: steps.assert-write-access.outcome == 'success'
# Only run this step if a user has write access and metadata was successfully extracted:
if: steps.assert-write-access.outcome == 'success' && steps.extract-metadata.outcome == 'success'

# Pin action to full length commit SHA
uses: stdlib-js/metadata-tweet-action@8e9b688c86150797c1c7f60bc8f7c9a9a30e10fe # v2.0.0
Expand All @@ -111,8 +114,8 @@ jobs:
- name: 'Check metadata for workflow dispatch directives'
id: check-workflow-dispatch

# Only run this step if a user has write access:
if: steps.assert-write-access.outcome == 'success'
# Only run this step if a user has write access and metadata was successfully extracted:
if: steps.assert-write-access.outcome == 'success' && steps.extract-metadata.outcome == 'success'

env:
METADATA: ${{ steps.extract-metadata.outputs.metadata }}
Expand Down