chore: add unsigned keyword to number/uint32/base/add and sub#12831
Draft
Planeshifter wants to merge 2 commits into
Draft
chore: add unsigned keyword to number/uint32/base/add and sub#12831Planeshifter wants to merge 2 commits into
unsigned keyword to number/uint32/base/add and sub#12831Planeshifter wants to merge 2 commits into
Conversation
The `unsigned` keyword is present in 8 of the 10 sibling `@stdlib/number/uint32/base/*` packages (80% conformance); `add` and `sub` were the only outliers. The function operates on unsigned 32-bit integers, so the keyword applies. https://claude.ai/code/session_019SVGtKk9jEos5C9ecE4ni2
The `unsigned` keyword is present in 8 of the 10 sibling `@stdlib/number/uint32/base/*` packages (80% conformance); `add` and `sub` were the only outliers. The function operates on unsigned 32-bit integers, so the keyword applies. https://claude.ai/code/session_019SVGtKk9jEos5C9ecE4ni2
Contributor
Coverage Report
The above coverage report was generated for the changes in this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds the
"unsigned"keyword to thepackage.jsonof@stdlib/number/uint32/base/addand@stdlib/number/uint32/base/subto bring them in line with the 80% sibling conformance rate within@stdlib/number/uint32/base.@stdlib/number/uint32/base/addThe
keywordsarray lacked"unsigned", which 8 of 10 packages (80%) in@stdlib/number/uint32/baseinclude. The keyword applies: the package operates on unsigned 32-bit integers via>>>0coercion and documents operands as{uinteger}.@stdlib/number/uint32/base/subThe
keywordsarray lacked"unsigned", diverging from the 80% sibling conformance rate within@stdlib/number/uint32/base. The keyword is semantically correct given the package's use of>>>0coercion and{uinteger}JSDoc annotations.Related Issues
No.
Questions
No.
Other
Pure
package.jsonmetadata change; no runtime behavior, public signature, or test expectation is affected. Precedent for this exact correction shape: #12816 (stats/base/dists/poissoncountskeyword) and #12830 (stats/base/dists/negative-binomialkeyword alignment).Checklist
AI Assistance
If you answered "yes" above, how did you use AI assistance?
Disclosure
This PR was drafted by Claude Code as part of a cross-package API drift audit of the
@stdlib/number/uint32/basenamespace: structural and semantic features were extracted across all 10 members, a single high-signal outlier feature was identified ("unsigned"keyword absent inaddandsubdespite 8/10 sibling conformance), and three-agent validation (semantic / cross-reference / structural) returnedconfirmed-driftfor both packages before the fix was applied.@stdlib-js/reviewers
Generated by Claude Code