Skip to content

test: migrate math/base/special/atanf to ULP-based testing#12795

Draft
Planeshifter wants to merge 1 commit into
developfrom
philipp/ulp-atanf
Draft

test: migrate math/base/special/atanf to ULP-based testing#12795
Planeshifter wants to merge 1 commit into
developfrom
philipp/ulp-atanf

Conversation

@Planeshifter

Copy link
Copy Markdown
Member

Resolves a part of #11352.

Description

What is the purpose of this pull request?

This pull request:

  • migrates test/test.js and test/test.native.js in math/base/special/atanf from relative-tolerance (EPS-based) assertions to ULP-difference assertions via @stdlib/number/float32/base/assert/is-almost-same-value (the single-precision variant, following the precedent of math/base/special/acothf and math/base/special/atanhf)
  • uses the minimum required ULP values per test block, verified by direct ULP-difference computation over the test fixtures via @stdlib/number/float32/base/ulp-difference: the tiny_negative, tiny_positive, huge_negative, and huge_positive blocks match exactly (ULP 0) and therefore use plain t.strictEqual, the [ -0.8, 0.8 ] block requires 3 ULPs (the original test used a widened 1.8 * EPS tolerance there), and all remaining blocks require 1 ULP
  • applies the same ULP values to the native test file; the native (C) results do not diverge from the JavaScript results, so no compiler-optimization tolerance note is needed

Related Issues

Does this pull request have any related issues?

This pull request has the following related issues:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

Minimality of the ULP values was verified by recomputing the maximum ULP difference per fixture block and by confirming that reducing the [ -0.8, 0.8 ] block from 3 to 2 ULPs fails in both the JavaScript and native test suites. The full JavaScript and native test suites pass with these values (6514/6514 assertions each).

Checklist

Please ensure the following tasks are completed before submitting this pull request.

AI Assistance

When authoring the changes proposed in this PR, did you use any kind of AI assistance?

  • Yes
  • No

If you answered "yes" above, how did you use AI assistance?

  • Code generation (e.g., when writing an implementation or fixing a bug)
  • Test/benchmark generation
  • Documentation (including examples)
  • Research and understanding

Disclosure

This PR was written primarily by Claude Code, including the test migration, minimum-ULP discovery, and an independent adversarial verification pass that recomputed the per-block ULP values from the fixtures.


@stdlib-js/reviewers

---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown_pkg_readmes
    status: na
  - task: lint_markdown_docs
    status: na
  - task: lint_markdown
    status: na
  - task: lint_package_json
    status: na
  - task: lint_repl_help
    status: na
  - task: lint_javascript_src
    status: na
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: na
  - task: lint_javascript_tests
    status: passed
  - task: lint_javascript_benchmarks
    status: na
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: na
  - task: lint_c_examples
    status: na
  - task: lint_c_benchmarks
    status: na
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: passed
  - task: lint_typescript_tests
    status: na
  - task: lint_license_headers
    status: passed
---
@stdlib-bot stdlib-bot added Math Issue or pull request specific to math functionality. Good First PR A pull request resolving a Good First Issue. labels Jun 10, 2026
@stdlib-bot

Copy link
Copy Markdown
Contributor

Hello! 👋

We've noticed that you've been opening a number of PRs addressing good first issues. Thank you for your interest and enthusiasm!

Now that you've made a few contributions, we suggest no longer working on good first issues. Instead, we encourage you to prioritize cleaning up any PRs which have yet to be merged and then proceed to work on more involved tasks.

Not only does this ensure that other new contributors can work on things and get ramped up on all things stdlib, it also ensures that you can spend your time on more challenging problems. 🚀

For ideas for future PRs, feel free to search the codebase for TODOs and FIXMEs and be sure to check out other open issues on the issue tracker. Cheers!

@stdlib-bot

Copy link
Copy Markdown
Contributor

Coverage Report

Package Statements Branches Functions Lines
math/base/special/atanf $\\color{green}284/284$
$\\color{green}+100.00\\%$
$\\color{green}21/21$
$\\color{green}+100.00\\%$
$\\color{green}3/3$
$\\color{green}+100.00\\%$
$\\color{green}284/284$
$\\color{green}+100.00\\%$

The above coverage report was generated for the changes in this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Good First PR A pull request resolving a Good First Issue. Math Issue or pull request specific to math functionality.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants