Skip to content

test: migrate math/base/special/fmodf to ULP-based testing#12791

Draft
Planeshifter wants to merge 1 commit into
developfrom
philipp/ulp-fmodf
Draft

test: migrate math/base/special/fmodf to ULP-based testing#12791
Planeshifter wants to merge 1 commit into
developfrom
philipp/ulp-fmodf

Conversation

@Planeshifter

Copy link
Copy Markdown
Member

Resolves a part of #11352.

Description

What is the purpose of this pull request?

This pull request:

  • migrates test/test.js and test/test.native.js of @stdlib/math/base/special/fmodf from relative-tolerance (EPS-based) assertions to exact-equality assertions, per the migration guidelines in [RFC]: Migrate math/base/special packages from relative tolerance testing to ULP difference testing (tracking issue) #11352.
  • Independent ULP-difference computation (via @stdlib/number/float32/base/ulp-difference, with single-precision coercion of inputs and expected values exactly as performed in the tests) over all 7 fixture blocks (20004 cases) measured a maximum ULP difference of 0 for every block. As fmod is exact per IEEE 754, every assertion was therefore converted to a plain t.strictEqual( v, e, 'returns expected value' ) rather than isAlmostSameValue, following maintainer guidance that isAlmostSameValue should not be used where values are exactly equal.
  • removes the now-unused EPS (@stdlib/constants/float32/eps) and absf requires and the delta/tol variables.
  • Native (C) tests were built and run (not skipped) and pass with identical exact-equality assertions: no JS/C divergence was observed, so no tolerance NOTE annotations were necessary.

Related Issues

Does this pull request have any related issues?

This pull request has the following related issues:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

AI Assistance

When authoring the changes proposed in this PR, did you use any kind of AI assistance?

  • Yes
  • No

If you answered "yes" above, how did you use AI assistance?

  • Code generation (e.g., when writing an implementation or fixing a bug)
  • Test/benchmark generation
  • Documentation (including examples)
  • Research and understanding

Disclosure

This PR was written by Claude Code: an automated agent performed the test migration and computed the minimum required ULP values, and an independent adversarial verification agent recomputed the ULP values over all fixtures and reviewed the diff before opening this PR.


@stdlib-js/reviewers

---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown_pkg_readmes
    status: na
  - task: lint_markdown_docs
    status: na
  - task: lint_markdown
    status: na
  - task: lint_package_json
    status: na
  - task: lint_repl_help
    status: na
  - task: lint_javascript_src
    status: na
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: na
  - task: lint_javascript_tests
    status: passed
  - task: lint_javascript_benchmarks
    status: na
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: na
  - task: lint_c_examples
    status: na
  - task: lint_c_benchmarks
    status: na
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: passed
  - task: lint_typescript_tests
    status: na
  - task: lint_license_headers
    status: passed
---
@stdlib-bot stdlib-bot added Math Issue or pull request specific to math functionality. Good First PR A pull request resolving a Good First Issue. labels Jun 10, 2026
@stdlib-bot

Copy link
Copy Markdown
Contributor

Coverage Report

Package Statements Branches Functions Lines
math/base/special/fmodf $\\color{green}188/188$
$\\color{green}+100.00\\%$
$\\color{green}5/5$
$\\color{green}+100.00\\%$
$\\color{green}2/2$
$\\color{green}+100.00\\%$
$\\color{green}188/188$
$\\color{green}+100.00\\%$

The above coverage report was generated for the changes in this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Good First PR A pull request resolving a Good First Issue. Math Issue or pull request specific to math functionality.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants