[6.x] Improve focus on page load #13357
Merged
+50
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
This seems like an improvement overall, though I'm noticing a few places autofocus doesn't catch properly on an Inertia request:
...basically all the Create New Container-level things. Create new Entry etc works great. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #13233, this fixes page focus state when navigating around the CP with Inertia.
Usually, the focus state would be reset on each page load, but Inertia keeps keyboard focus it in its current position, which is undesirable.
This PR loads checks explicitly-set focus states first.
If no focus state is set, then we fall back to setting keyboard focus on the
#main-contentThis along with #13356 should close #13233