Move shinystan to suggests and bump Roxygen - #653
Open
VisruthSK wants to merge 6 commits into
Open
Conversation
jgabry
reviewed
Jul 24, 2026
Member
To suggests not imports. Thanks for doing this. See my one review comment, which is really a question |
Member
|
We're getting this error:
|
Member
https://github.com/stan-dev/rstanarm/actions/runs/30084028618/job/89451905454?pr=653#step:7:84 |
Member
Author
|
Fixed, and fixed some roxygen messages while I was at it. Just some linebreaks in import statements it didn't like. |
VisruthSK
changed the title
Member
Author
|
I think these errors are unrelated: https://github.com/stan-dev/rstanarm/actions/runs/30122362006/job/89577779271#step:7:1 Though should be fixed of course. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR was made with assistance from ChatGPT.
Move shinystan to suggests and defining a small compat helper to ensure the API doesn't change. Also bumps roxygen to v8, deleted test plots artifact, and forced lf normalization.
Fixes #623.