Skip to content

Conversation

@JayceFayne
Copy link

@JayceFayne JayceFayne commented Jan 29, 2026

The goal of this PR was to parse embedded rfc822 messages (eagerly).
For example:

From: [email protected]
To: [email protected]
Subject: Wrapper message
MIME-Version: 1.0
Content-Type: message/rfc822

From: [email protected]
To: [email protected]
Subject: Embedded message
MIME-Version: 1.0
Content-Type: text/plain

Hi

Is not being parsed but instead you get a binary body...which is fine.
It turns out adding this feature would just add unneccesarry complexity. I am opening this PR to upstream some refactors that make the parse_mail_recursive function much more readable.

@JayceFayne JayceFayne changed the title ~~eagerly parse embedded messages~~ some refactors to make the code more readable some refactors to make the code more readable Jan 29, 2026
@JayceFayne JayceFayne mentioned this pull request Jan 30, 2026
Copy link
Owner

@staktrace staktrace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Overall this is a nice cleanup. I'd prefer to drop the second commit but the other three look good

@JayceFayne
Copy link
Author

Dropped the second commit

@staktrace
Copy link
Owner

Please rebase and resolve conflicts here. Thanks again for all the PRs!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants