ROX-35590: Expose gcp-project as parameter for gke-default flavor

[tommartensen]

No description provided.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Central YAML (base), Organization UI (inherited)

Review profile: CHILL

Plan: Pro Plus

Run ID: ce7287c6-3d2f-4596-8c84-4f9db3a0393c

📥 Commits

Reviewing files that changed from the base of the PR and between 299a1d6 and e7c92a4.

📒 Files selected for processing (4)

• chart/infra-server/static/flavors.yaml
• chart/infra-server/static/janitor-delete-gke-default.yaml
• chart/infra-server/static/test-gke-lite.yaml
• chart/infra-server/static/workflow-gke-default.yaml

🚧 Files skipped from review as they are similar to previous changes (3)

• chart/infra-server/static/test-gke-lite.yaml
• chart/infra-server/static/workflow-gke-default.yaml
• chart/infra-server/static/janitor-delete-gke-default.yaml

---

📝 Walkthrough

Summary by CodeRabbit

• New Features
  • Added an optional gcp-project setting for GKE deployment workflows.
  • The default GKE configuration uses acs-team-temp-dev when no project is specified.
  • Create, test, and cleanup workflows now use the selected Google Cloud project.
  • Testing workflows can accept the project as an input instead of relying on a fixed value.

Walkthrough

Changes

The GKE flavors now expose a configurable gcp-project parameter, and related workflows pass it to GKE create and destroy commands instead of using a hardcoded project.

GKE project parameterization

Layer / File(s)	Summary
Project parameter contract chart/infra-server/static/flavors.yaml	Adds optional gcp-project parameters with default value acs-team-temp-dev to the GKE-related flavors.
Workflow project wiring chart/infra-server/static/janitor-delete-gke-default.yaml, chart/infra-server/static/test-gke-lite.yaml, chart/infra-server/static/workflow-gke-default.yaml	Adds workflow inputs and passes them to GKE create and destroy commands.

Estimated code review effort: 2 (Simple) | ~10 minutes

Suggested reviewers: bradlugo, davdhacs

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name	Status	Explanation	Resolution
Description check	❓ Inconclusive	No pull request description was provided, so there is nothing to assess for relatedness.	Add a short description summarizing the workflow and flavor parameter changes.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title matches the main change: making gcp-project configurable for the gke-default flavor.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch tm/ROX-35590-gke-project

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[coderabbitai]

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@chart/infra-server/static/flavors.yaml`:
- Around line 187-191: The GKE janitor and test workflows lack the gcp-project
contract and do not propagate the project value. In
chart/infra-server/static/flavors.yaml lines 187-191, add matching gcp-project
parameters to janitor-delete-gke-default and test-gke-lite; in
chart/infra-server/static/janitor-delete-gke-default.yaml lines 12-13 and 36,
receive the flavor value and pass it to destroy; in
chart/infra-server/static/test-gke-lite.yaml lines 21-22, 77, and 100, receive
the value and pass it to create and destroy.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Central YAML (base), Organization UI (inherited)

Review profile: CHILL

Plan: Pro Plus

Run ID: 495eb4b4-a7f7-4c65-90df-b1d746b67dbc

📥 Commits

Reviewing files that changed from the base of the PR and between c3d91a7 and 299a1d6.

📒 Files selected for processing (4)

• chart/infra-server/static/flavors.yaml
• chart/infra-server/static/janitor-delete-gke-default.yaml
• chart/infra-server/static/test-gke-lite.yaml
• chart/infra-server/static/workflow-gke-default.yaml

[rhacs-bot]

A single node development cluster (infra-pr-1893) was allocated in production infra for this PR.

CI will attempt to deploy quay.io/rhacs-eng/infra-server: to it.

🔌 You can connect to this cluster with:

gcloud container clusters get-credentials infra-pr-1893 --zone us-central1-a --project acs-team-temp-dev

🛠️ And pull infractl from the deployed dev infra-server with:

nohup kubectl -n infra port-forward svc/infra-server-service 8443:8443 &
make pull-infractl-from-dev-server

🔓 You must go to to export an . Your token from the prod infra instance will not work with dev environments.

🚲 You can then use the dev infra instance e.g.:

bin/infractl -k -e localhost:8443 whoami

⚠️ Any clusters that you start using your dev infra instance should have a lifespan shorter then the development cluster instance. Otherwise they will not be destroyed when the dev infra instance ceases to exist when the development cluster is deleted. ⚠️

Further Development

☕ If you make changes, you can commit and push and CI will take care of updating the development cluster.

🚀 If you only modify configuration (chart/infra-server/configuration) or templates (chart/infra-server/{static,templates}), you can get a faster update with:

make helm-deploy

Logs

Logs for the development infra depending on your @redhat.com authuser:

• authuser=0
• authuser=1
• authuser=2

Or:

kubectl -n infra logs -l app=infra-server --tail=1 -f