-
Notifications
You must be signed in to change notification settings - Fork 2
Document private Git repository authentication for Registry Server #513
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Add documentation for configuring authentication when using private Git repositories as a registry source. Includes configuration options for username and passwordFile, along with a Kubernetes deployment example showing how to mount secrets. Closes stacklok/toolhive-registry-server#439 Co-Authored-By: Claude Opus 4.5 <[email protected]>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Adds documentation describing how to configure authentication when using private Git repositories as a ToolHive Registry Server registry source.
Changes:
- Documents the
git.authconfiguration block for private repos, includingauth.usernameandauth.passwordFile. - Adds a Kubernetes example demonstrating mounting a Secret and referencing the mounted token file.
Signed-off-by: Chris Burns <[email protected]>
Signed-off-by: Chris Burns <[email protected]>
| - name: data | ||
| mountPath: /data | ||
| readOnly: false |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Side note for future improvement: the /data path is used a bunch of times in this doc, but never actually explained.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've added a note for this 👍 give it a look and let me know what you think
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, it feels kind of random there (also the grammar is off - "in order to storage").
But looking at it again, I guess this IS the first time mounting a volume as /data is done. This begs the question, why isn't it introduced above in the main "Git repository source" section? Then, having it appear again in the authenticated example would make sense without an extra note.
Is it required (must not be since I don't have it in my config)? If not, why/when use it?
Signed-off-by: Chris Burns <[email protected]>
Summary
auth.usernameandauth.passwordFileconfiguration optionsCloses stacklok/toolhive-registry-server#439
Test plan
npm run build)stacklok/toolhive-registry-server#439
🤖 Generated with Claude Code