Skip to content

ci: fix zizmor findings in GitHub Actions workflows - #911

Merged
danbarr merged 1 commit into
mainfrom
ci/zizmor-findings
Aug 26, 2026
Merged

ci: fix zizmor findings in GitHub Actions workflows#911
danbarr merged 1 commit into
mainfrom
ci/zizmor-findings

Conversation

@danbarr

@danbarr danbarr commented Aug 26, 2026

Copy link
Copy Markdown
Contributor

Follow-up to the zizmor workflow added in the previous commit: addresses the findings it surfaces across the existing workflows now that the scan is in place.

  • Sets persist-credentials explicitly on every checkout: false where the job never pushes, true (with a comment) where it does and genuinely needs the persisted credential.
  • Disables setup-go's default caching in the container-build job that publishes runtime artifacts, per zizmor's cache-poisoning audit.
  • Swaps the spoofable github.actor bot check in skill-version-check.yml for github.event.pull_request.user.login.
  • Suppresses the dangerous-triggers finding on the two workflow_run based report workflows with a documented rationale: neither checks out or executes the triggering run's code, and the only untrusted value they consume (a PR number read from an artifact) only affects which PR gets commented on.

With the zizmor workflow gating on medium+ severity only, this clears everything at that threshold. The remaining low/informational findings (template-injection warnings on already-scoped env values,
one ad-hoc npm install) are left as-is.

Co-Authored-By: Claude Sonnet 5 noreply@anthropic.com


Stack created with GitHub Stacks CLIGive Feedback 💬

@toolhive-release-app

Copy link
Copy Markdown
Contributor

🛡️ Skill Security Scan Results

✅ agent-observability-eval-bootstrap

  • Status: Passed
  • Findings: 4
  • Allowed (not blocking): 1
    • MANIFEST_MISSING_LICENSE (Allowed: datadog-labs/agent-skills is licensed MIT at the repository root; upstream does not embed an SPDX license identifier in per-skill SKILL.md frontmatter.)

Summary: Scanned 1 skill(s), all passed security checks. ✅

@danbarr
danbarr marked this pull request as ready for review August 26, 2026 02:38
@toolhive-release-app

Copy link
Copy Markdown
Contributor

🔒 MCP Security Scan Results

✅ adb-mysql-mcp-server

  • Status: Passed
  • Tools scanned: 3
  • Result: No security issues detected

✅ agentql-mcp

  • Status: Passed
  • Tools scanned: 1
  • Result: No security issues detected

Summary: Scanned 2 MCP server(s), all passed security checks. ✅

Base automatically changed from ci/add-zizmor to main August 26, 2026 20:16
Follow-up to the zizmor workflow added in the previous commit:
addresses the findings it surfaces across the existing workflows now
that the scan is in place.

- Sets persist-credentials explicitly on every checkout: false where
  the job never pushes, true (with a comment) where it does and
  genuinely needs the persisted credential.
- Disables setup-go's default caching in the container-build job that
  publishes runtime artifacts, per zizmor's cache-poisoning audit.
- Swaps the spoofable github.actor bot check in
  skill-version-check.yml for github.event.pull_request.user.login.
- Suppresses the dangerous-triggers finding on the two workflow_run
  based report workflows with a documented rationale: neither checks
  out or executes the triggering run's code, and the only untrusted
  value they consume (a PR number read from an artifact) only affects
  which PR gets commented on.

With the zizmor workflow gating on medium+ severity only, this clears
everything at that threshold. The remaining low/informational
findings (template-injection warnings on already-scoped env values,
one ad-hoc npm install) are left as-is.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
@danbarr
danbarr force-pushed the ci/zizmor-findings branch from 0bc2f2a to 7c456ab Compare August 26, 2026 20:16
@danbarr
danbarr merged commit 1aee777 into main Aug 26, 2026
15 checks passed
@danbarr
danbarr deleted the ci/zizmor-findings branch August 26, 2026 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants