ci: fix zizmor findings in GitHub Actions workflows - #911
Merged
Conversation
Contributor
🛡️ Skill Security Scan Results✅ agent-observability-eval-bootstrap
Summary: Scanned 1 skill(s), all passed security checks. ✅ |
danbarr
marked this pull request as ready for review
August 26, 2026 02:38
Contributor
🔒 MCP Security Scan Results✅ adb-mysql-mcp-server
✅ agentql-mcp
Summary: Scanned 2 MCP server(s), all passed security checks. ✅ |
JAORMX
approved these changes
Aug 26, 2026
Follow-up to the zizmor workflow added in the previous commit: addresses the findings it surfaces across the existing workflows now that the scan is in place. - Sets persist-credentials explicitly on every checkout: false where the job never pushes, true (with a comment) where it does and genuinely needs the persisted credential. - Disables setup-go's default caching in the container-build job that publishes runtime artifacts, per zizmor's cache-poisoning audit. - Swaps the spoofable github.actor bot check in skill-version-check.yml for github.event.pull_request.user.login. - Suppresses the dangerous-triggers finding on the two workflow_run based report workflows with a documented rationale: neither checks out or executes the triggering run's code, and the only untrusted value they consume (a PR number read from an artifact) only affects which PR gets commented on. With the zizmor workflow gating on medium+ severity only, this clears everything at that threshold. The remaining low/informational findings (template-injection warnings on already-scoped env values, one ad-hoc npm install) are left as-is. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
danbarr
force-pushed
the
ci/zizmor-findings
branch
from
August 26, 2026 20:16
0bc2f2a to
7c456ab
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to the zizmor workflow added in the previous commit: addresses the findings it surfaces across the existing workflows now that the scan is in place.
With the zizmor workflow gating on medium+ severity only, this clears everything at that threshold. The remaining low/informational findings (template-injection warnings on already-scoped env values,
one ad-hoc npm install) are left as-is.
Co-Authored-By: Claude Sonnet 5 noreply@anthropic.com
Stack created with GitHub Stacks CLI • Give Feedback 💬