fix: Port the serviceAccount.name/create fix into the template - #634
Open
lfrancke wants to merge 1 commit into
Open
fix: Port the serviceAccount.name/create fix into the template#634lfrancke wants to merge 1 commit into
lfrancke wants to merge 1 commit into
Conversation
Same change as hive-operator#742:
- the Deployment and the ServiceAccount both resolve their name through
operator.serviceAccountName instead of hardcoding <fullname>-serviceaccount,
which is what makes .Values.serviceAccount.name take effect at all
- with create=false the helper used to fall back to "default", giving a pod
without the operator's ClusterRole; it now requires serviceAccount.name
lfrancke
marked this pull request as ready for review
August 16, 2026 17:55
This was referenced Aug 16, 2026
Techassi
reviewed
Aug 17, 2026
| {{- define "operator.serviceAccountName" -}} | ||
| {{- if .Values.serviceAccount.create }} | ||
| {{- default (include "operator.fullname" .) .Values.serviceAccount.name }} | ||
| {{- default (printf "%s-serviceaccount" (include "operator.fullname" .)) .Values.serviceAccount.name }} |
Member
There was a problem hiding this comment.
Technically, we don't need to include -serviceaccount in the name, because the kind already indicates what the object is, a ServiceAccount.
We also do this in various other places, like the Deployments the operator creates. It wastes valuable characters and also duplicates information.
Techassi
moved this from Development: Waiting for Review
to Development: In Review
in Stackable Engineering
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ports stackabletech/hive-operator#742 into the template.
operator.serviceAccountNameinstead of hardcoding<fullname>-serviceaccount, which is what makes.Values.serviceAccount.nametake effect at allcreate=falsethe helper fell back to"default", giving a pod running as the namespace default ServiceAccount without the operator ClusterRole. It now requiresserviceAccount.name.This should not be rolled out before stackabletech/listener-operator#418 and stackabletech/secret-operator#736 are merged.