Skip to content

refactor: Update generic database connection test to use Deref trait#1193

Merged
sbernauer merged 1 commit into
mainfrom
refactor/database-connection-test
Apr 9, 2026
Merged

refactor: Update generic database connection test to use Deref trait#1193
sbernauer merged 1 commit into
mainfrom
refactor/database-connection-test

Conversation

@sbernauer
Copy link
Copy Markdown
Member

Description

We already do this in the operator implementations and should recommend that

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes

Author

  • Changes are OpenShift compatible
  • CRD changes approved
  • CRD documentation for all fields, following the style guide.
  • Integration tests passed (for non trivial changes)
  • Changes need to be "offline" compatible

Reviewer

  • Code contains useful comments
  • Code contains useful logging statements
  • (Integration-)Test cases added
  • Documentation added or updated. Follows the style guide.
  • Changelog updated
  • Cargo.toml only contains references to git tags (not specific commits or branches)

Acceptance

  • Feature Tracker has been updated
  • Proper release label has been added

We already do this in the operator implementations
@sbernauer sbernauer self-assigned this Apr 8, 2026
@sbernauer sbernauer moved this to Development: Waiting for Review in Stackable Engineering Apr 8, 2026
@sbernauer sbernauer enabled auto-merge April 8, 2026 11:01
@sbernauer sbernauer requested review from a team and Techassi April 8, 2026 11:02
Copy link
Copy Markdown
Member

@xeniape xeniape left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sbernauer sbernauer added this pull request to the merge queue Apr 9, 2026
Merged via the queue into main with commit 03913eb Apr 9, 2026
5 checks passed
@sbernauer sbernauer deleted the refactor/database-connection-test branch April 9, 2026 07:45
@Techassi Techassi moved this from Development: Waiting for Review to Development: Done in Stackable Engineering Apr 9, 2026
@lfrancke lfrancke moved this from Development: Done to Done in Stackable Engineering Apr 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

4 participants