Skip to content

refactor: Introduce build aggregator#776

Open
maltesander wants to merge 4 commits into
mainfrom
feat/smooth-operator/introduce-builder
Open

refactor: Introduce build aggregator#776
maltesander wants to merge 4 commits into
mainfrom
feat/smooth-operator/introduce-builder

Conversation

@maltesander

Copy link
Copy Markdown
Member

Description

Part of stackabletech/issues#864.

  • Plain KubernetesResources; fallible build(cluster, sa_name) reusing existing builders
  • Reconcile rewritten to a build-then-apply loop (StatefulSets last)
  • Built-SA name

Moved the discovery configmap into the build (outdated comment stated it has to be applied last - tests work)

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes

Author

  • Changes are OpenShift compatible
  • CRD changes approved
  • CRD documentation for all fields, following the style guide.
  • Helm chart can be installed and deployed operator works
  • Integration tests passed (for non trivial changes)
  • Changes need to be "offline" compatible
  • Links to generated (nightly) docs added
  • Release note snippet added

Reviewer

  • Code contains useful comments
  • Code contains useful logging statements
  • (Integration-)Test cases added
  • Documentation added or updated. Follows the style guide.
  • Changelog updated
  • Cargo.toml only contains references to git tags (not specific commits or branches)

Acceptance

  • Feature Tracker has been updated
  • Proper release label has been added
  • Links to generated (nightly) docs added
  • Release note snippet added
  • Add type/deprecation label & add to the deprecation schedule
  • Add type/experimental label & add to the experimental features tracker

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant