Allow OS to choose the best protocol to use#547
Open
lwalejko wants to merge 1 commit intosta:masterfrom
Open
Conversation
…hat are not secure. This setting is recommended by SslProtocols Enum documentation.
eynzhang
approved these changes
Dec 10, 2019
eynzhang
left a comment
eynzhang
left a comment
There was a problem hiding this comment.
I agree with this as I encountered same issue when initializing the connection, and I found the same root cause while looking at the source code.
Author
|
I forgot about this pull request to be honest ;) @eynzhang have you tried if this change works for you as intended? I had some more problems with this and ended up using System.Security.Authentication.SslProtocols.Tls12 value directly. |
|
I think that’s depends on the settings in server, in my cases ‘None’ is working for me. That’s why I proposed a request on the readme document here: Maybe a better way is to pass this property by the constructor or a public method. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As per documentation (https://docs.microsoft.com/en-us/dotnet/api/system.security.authentication.sslprotocols?view=netframework-4.8),
Noneshould be used as default value, notDefault, becauseDefaultallows only outdated and less secure protocols.