Stop CoreJacksonModule from overriding user DateTimeFeature configuration#19043
Open
hqqw2h-lgtm wants to merge 1 commit intospring-projects:mainfrom
Open
Stop CoreJacksonModule from overriding user DateTimeFeature configuration#19043hqqw2h-lgtm wants to merge 1 commit intospring-projects:mainfrom
hqqw2h-lgtm wants to merge 1 commit intospring-projects:mainfrom
Conversation
spring-projects-issues
added
the
status: waiting-for-triage
…tion Remove the global DateTimeFeature.WRITE_DATES_AS_TIMESTAMPS override from CoreJacksonModule.setupModule() and use @jsonformat(shape = NUMBER) on Mixin parameters/getters that need timestamp format for backward compatibility. Closes spring-projectsgh-18561 Signed-off-by: hanweiwei <duzielww@163.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #18561
CoreJacksonModule.setupModule() unconditionally called enable(DateTimeFeature.WRITE_DATES_AS_TIMESTAMPS) on the MapperBuilder, which overrode any user configuration and forced all java.time types (e.g. LocalDateTime, Instant) to be serialized as timestamps/arrays instead of ISO-8601 strings.
Changes