Add allowed scopes validation for DCR endpoints#19040
Open
addcontent wants to merge 1 commit intospring-projects:mainfrom
Open
Add allowed scopes validation for DCR endpoints#19040addcontent wants to merge 1 commit intospring-projects:mainfrom
addcontent wants to merge 1 commit intospring-projects:mainfrom
Conversation
Add allowedScopes configuration to both OAuth2 and OIDC Dynamic Client Registration endpoints. When configured, registration requests containing scopes not in the allowed set are rejected with an invalid_scope error. This addresses the scenario where DCR accepts arbitrary scope strings verbatim, which could result in dynamically registered clients obtaining tokens with unintended privilege scopes. Changes: - Add setAllowedScopes(Set<String>) to both authentication providers - Add allowedScopes(String...) to both endpoint configurers - Add documentation with security considerations for DCR scope validation - Add tests for scope validation, backward compatibility, and null safety Signed-off-by: addcontent <addcontent08@gmail.com>
spring-projects-issues
added
the
status: waiting-for-triage
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add
allowedScopesconfiguration to both OAuth2 and OIDC Dynamic Client Registration endpoints, along with documentation recommending its use.Currently, DCR accepts any scope string verbatim during client registration. This PR adds a built-in mechanism to restrict which scopes are permitted, complementing the existing
setRegisteredClientConverter()extension point with a simpler configuration option.This was discussed in GHSA-wrvg-67fj-c87r, where @jgrandja agreed on adding documentation and considering a security enhancement.
Changes
setAllowedScopes(Set<String>)toOidcClientRegistrationAuthenticationProviderandOAuth2ClientRegistrationAuthenticationProviderallowedScopes(String...)fluent API to both endpoint configurersprotocol-endpoints.adocBehavior
allowedScopesis configured, registration requests with scopes outside the set are rejected withinvalid_scopeopenRegistrationAllowedSigned-off-by: addcontent addcontent08@gmail.com