Apply SessionAuthenticationStrategy to WebAuthnAuthenticationFilter#19039
Open
hqqw2h-lgtm wants to merge 2 commits intospring-projects:mainfrom
Open
Apply SessionAuthenticationStrategy to WebAuthnAuthenticationFilter#19039hqqw2h-lgtm wants to merge 2 commits intospring-projects:mainfrom
hqqw2h-lgtm wants to merge 2 commits intospring-projects:mainfrom
Conversation
spring-projects-issues
added
the
status: waiting-for-triage
Contributor
|
slop |
WebAuthnConfigurer did not wire the shared SessionAuthenticationStrategy into WebAuthnAuthenticationFilter, so session concurrency limits were bypassed during passkey authentication. Closes spring-projectsgh-16685 Signed-off-by: hanweiwei <duzielww@163.com>
Author
|
Thanks for the feedback. I've pushed a fix to address the issues: removed the accidentally committed temp file, corrected import ordering, and strengthened the test to verify the SessionAuthenticationStrategy is actually applied (using ReflectionTestUtils). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix session concurrency control being bypassed during passkey (WebAuthn) authentication.
Root Cause:
WebAuthnConfigurerdid not apply theSessionAuthenticationStrategytoWebAuthnAuthenticationFilter. WhenmaximumSessions(1)was configured, the constraint was enforced for form-based login but not for passkey login.Fix: Retrieve the shared
SessionAuthenticationStrategyand set it onWebAuthnAuthenticationFilter, following the same pattern used byAbstractAuthenticationFilterConfigurerandRememberMeConfigurer.SessionAuthenticationStrategywiring inWebAuthnConfigurer.configure()Closes gh-16685