Add XML guidance to authorizeRequests deprecation warning#19033
Open
hqqw2h-lgtm wants to merge 1 commit intospring-projects:mainfrom
Open
Add XML guidance to authorizeRequests deprecation warning#19033hqqw2h-lgtm wants to merge 1 commit intospring-projects:mainfrom
hqqw2h-lgtm wants to merge 1 commit intospring-projects:mainfrom
Conversation
spring-projects-issues
added
the
status: waiting-for-triage
The deprecation warning for authorizeRequests and FilterSecurityInterceptor now also includes guidance for XML-based configuration, advising users to add use-authorization-manager=true to their http element. Closes spring-projectsgh-17259 Signed-off-by: hanweiwei <duzielww@163.com> Signed-off-by: hanweiwei <duzielww@163.com>
hqqw2h-lgtm
force-pushed
the
gh-17259
branch
2 times, most recently
from
e7d5aa0 to
416890e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The deprecation warning for
authorizeRequestsandFilterSecurityInterceptornow also includes guidance for XML-based configuration, advising users to adduse-authorization-manager="true"to their<http>element.This addresses the feedback in gh-17259 where XML-based configuration users were seeing deprecation warnings with no clear guidance on how to resolve them in XML.
Changes:
DefaultFilterChainValidatorandWebSecurityFilterChainValidatorto include XML-specific guidanceCloses gh-17259