Publish authentication events in WebAuthn#18938
Merged
jzheaux merged 2 commits intospring-projects:mainfrom Apr 7, 2026
Merged
Publish authentication events in WebAuthn#18938jzheaux merged 2 commits intospring-projects:mainfrom
jzheaux merged 2 commits intospring-projects:mainfrom
Conversation
suuuuuuminnnnnn
force-pushed
the
gh-18113
branch
from
0d02a30 to
9af4217
Compare
spring-projects-issues
added
the
status: waiting-for-triage
jzheaux
added
type: enhancement
jzheaux
reviewed
Mar 31, 2026
Contributor
jzheaux
left a comment
jzheaux
left a comment
There was a problem hiding this comment.
Thanks, @suuuuuuminnnnnn! I've left some feedback inline.
.../java/org/springframework/security/config/annotation/web/configurers/WebAuthnConfigurer.java
Outdated
Show resolved
Hide resolved
Contributor
|
Terribly sorry, @suuuuuuminnnnnn, as I was preparing your PR for merging, I accidentally signed both my polish commit and your original commit. 😭 Are you able to re-checkout the PR and update the signature on your commit? |
jzheaux
changed the title
Author
|
no worries — i’ll re-sign my commit and force-push an updated |
Closes spring-projectsgh-18113 Signed-off-by: suuuuuuminnnnnn <sumin45402214@gmail.com>
Issue spring-projectsgh-18113 Signed-off-by: Josh Cummings <3627351+jzheaux@users.noreply.github.com>
suuuuuuminnnnnn
force-pushed
the
gh-18113
branch
from
20281d4 to
882e9e9
Compare
Contributor
|
Thanks for the PR, @suuuuuuminnnnnn! This is now merged into |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes gh-18113
WebAuthnConfigurer creates a ProviderManager directly via new ProviderManager(...),
bypassing the AuthenticationManagerBuilder pipeline that normally injects the
AuthenticationEventPublisher. As a result, WebAuthn authentication always uses
ProviderManager's default NullEventPublisher, silently ignoring any
AuthenticationEventPublisher bean registered by the user.
This commit wires the AuthenticationEventPublisher bean into the ProviderManager
using the existing getBeanOrNull() helper, matching the behavior of other
authentication mechanisms such as form login. If no bean is present, the existing
NullEventPublisher fallback is preserved.