Validation of deprecated io.buildpacks.stack.id is too aggressive - #51390
Open
scottfrederick wants to merge 1 commit into
Open
Validation of deprecated io.buildpacks.stack.id is too aggressive#51390scottfrederick wants to merge 1 commit into
scottfrederick wants to merge 1 commit into
Conversation
Spring Boot's Buildpacks integration inspects the stack IDs contained in labels on the builder image and run image. Prior to this change, it was a failure condition when the stack IDs did not match. Stack IDs have been deprecated in the CNB spec, and it is no longer required that the builder and run images match. The validation of stack IDs was changed from an error to a warning to match the `pack` reference implementation. Signed-off-by: Scott Frederick <scottyfred@gmail.com>
spring-projects-issues
added
the
status: waiting-for-triage
wilkinsona
changed the title
wilkinsona
added
type: bug
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #51166 (comment)