This repository was archived by the owner on Feb 5, 2022. It is now read-only.
Open
Conversation
…linting and testing before commits, added pacakge-lock.json, added _site and lib-cov with ignored contents instead of creating them every time, fix linting errors in bin and client.js
…de to keep from adding too many more deps
…move index.js and add a main entry to replace it
…ain field in package.json
…cal mock ssh server, along with the relevant mocks and mock server implementation. Also added coverage output in /coverage (ignored)
…ll request overrode the destination and defaulted to the home directory. Can check by uploading a file with a specified directory that isn't ~, the previous version still goes to ~ while the new goes to the specified.
…swords. Also require scp directly from bin instead of '..'
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello again!
So I realized I added a pretty terrible bug with my last PR (all uploaded files go to the root of the remote server, ignores destination). So I wanted to fix that, but I kind of got carried away. So I...
promptpackage, so passwords can be hiddenI also wanted to replace jshint with prettier (much smaller footprint when deving, and prettier is pretty standard at this point), add some coverage thresholds, and maybe beef up the local server so it actually writes files so all that logic can be checked, but that's for another day I guess.
Sorry for the massive PR, let me know if you'd like anything changed!