-
Notifications
You must be signed in to change notification settings - Fork 7
fix: validate ADDON Jira ticket in PR title #511
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
mkolasinski-splunk
wants to merge
7
commits into
develop
Choose a base branch
from
feat/validate-addon-jira-ticket-in-pr-title
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+95
−0
Open
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
0d982f0
feat: validate ADDON Jira ticket in PR title
mkolasinski-splunk e10389d
fix: harden ADDON Jira ticket title validation
mkolasinski-splunk 645bfb7
feat: comment on Jira ticket when referenced in a push commit
mkolasinski-splunk 44fe3e7
refactor: align Jira secrets with org convention (ATLASSIAN_EMAIL/TOKEN)
mkolasinski-splunk 1c8ba82
fix: grant pull-requests:read and stop leaking gh api errors into Jir…
mkolasinski-splunk 80f33e7
feat: match GitLab-style wording for Jira comment-on-push messages
mkolasinski-splunk 680bdd2
fix: comment on every ADDON ticket referenced in a commit message
mkolasinski-splunk File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These new workflow_call secrets are required, but existing callers use explicit
secrets:maps and do not pass them. Upgrading a caller to this workflow version will fail validation before any jobs run.Please update the repository template/callers as part of this rollout, or make these secrets optional until that rollout is complete.