Skip to content

Better distinguish error categories using different exit codes #648

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jviotti merged 9 commits into from
Feb 23, 2026
Merged

Better distinguish error categories using different exit codes #648

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
8594a7e
exit code 3 added
RitoG09 Feb 5, 2026
f826ca9
exit code 3 added:01
RitoG09 Feb 5, 2026
ee43d36
Merge branch 'main' into fix/#153
RitoG09 Feb 13, 2026
f94920f
Refactor exit code handling for category 3 errors
RitoG09 Feb 15, 2026
bcddbbe
Merge branch 'main' into fix/#153
jviotti Feb 23, 2026
c3ec785
Review
jviotti Feb 23, 2026
9aec98d
Fixes
jviotti Feb 23, 2026
15a50be
Fixes
jviotti Feb 23, 2026
250be1c
Formatting
jviotti Feb 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/command_lint.cc
View file
Open in desktop
Comment thread
RitoG09 marked this conversation as resolved.
Original file line number Diff line number Diff line change
Expand Up @@ -276,7 +276,7 @@ auto sourcemeta::jsonschema::lint(const sourcemeta::core::Options &options)
std::cerr << "\n";
Copy link
Copy Markdown

@cubic-dev-ai cubic-dev-ai Bot Feb 5, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1: The PR description states these paths should return exit code 3. However, FileError for CompilerReferenceTargetNotSchemaError, SchemaKeywordError, and SchemaFrameError is caught in src/error.h and explicitly returns EXIT_FAILURE (1), not 3. You must update src/error.h to return 3 for these error types to match the PR goal.

(Based on your team's feedback about reusing centralized error wrappers.)

View Feedback

Prompt for AI agents 
Check if this issue is valid — if so, understand the root cause and fix it. At src/command_lint.cc, line 287:

<comment>The PR description states these paths should return exit code 3. However, `FileError` for `CompilerReferenceTargetNotSchemaError`, `SchemaKeywordError`, and `SchemaFrameError` is caught in `src/error.h` and explicitly returns `EXIT_FAILURE` (1), not 3. You must update `src/error.h` to return 3 for these error types to match the PR goal.

(Based on your team's feedback about reusing centralized error wrappers.) </comment>

<file context>
@@ -276,31 +276,37 @@ auto sourcemeta::jsonschema::lint(const sourcemeta::core::Options &options)
               }
 
-              throw Fail{3};
+              throw FileError<sourcemeta::core::SchemaKeywordError>(entry.first,
+                                                                    error);
             } catch (const sourcemeta::core::SchemaFrameError &error) {
</file context>
Fix with Cubic

}

throw FileError<
throw FileError<
sourcemeta::blaze::CompilerReferenceTargetNotSchemaError>(
entry.first, error);
} catch (const sourcemeta::core::SchemaKeywordError &error) {
Expand Down Expand Up @@ -380,7 +380,7 @@ auto sourcemeta::jsonschema::lint(const sourcemeta::core::Options &options)
} catch (
const sourcemeta::blaze::CompilerReferenceTargetNotSchemaError
&error) {
throw FileError<
throw FileError<
sourcemeta::blaze::CompilerReferenceTargetNotSchemaError>(
entry.first, error);
} catch (const sourcemeta::core::SchemaKeywordError &error) {
Expand Down
1 change: 1 addition & 0 deletions src/command_validate.cc
View file
Open in desktop
Comment thread
RitoG09 marked this conversation as resolved.
Original file line number Diff line number Diff line change
Expand Up @@ -229,6 +229,7 @@ auto sourcemeta::jsonschema::validate(const sourcemeta::core::Options &options)
throw FileError<sourcemeta::core::SchemaError>(schema_path, error.what());
}


const auto schema_template{[&]() {
try {
return get_schema_template(bundled, custom_resolver, frame, fast_mode,
Expand Down
6 changes: 3 additions & 3 deletions src/error.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -462,7 +462,7 @@ inline auto try_catch(const sourcemeta::core::Options &options,
&error) {
const auto is_json{options.contains("json")};
print_exception(is_json, error);
return EXIT_FAILURE;
return 3;
} catch (const FileError<sourcemeta::core::SchemaResolutionError> &error) {
const auto is_json{options.contains("json")};
print_exception(is_json, error);
Expand All @@ -476,7 +476,7 @@ inline auto try_catch(const sourcemeta::core::Options &options,
}
}

return EXIT_FAILURE;
return 3;
} catch (
const FileError<sourcemeta::core::SchemaUnknownBaseDialectError> &error) {
const auto is_json{options.contains("json")};
Expand All @@ -491,7 +491,7 @@ inline auto try_catch(const sourcemeta::core::Options &options,
"`--default-dialect/-d`\n";
}

return EXIT_FAILURE;
return 3;
} catch (const FileError<sourcemeta::core::SchemaKeywordError> &error) {
const auto is_json{options.contains("json")};
print_exception(is_json, error);
Expand Down