Upgrade Core to e2864c369f7117a55aada78617fa2658938f0965#674
Merged
Conversation
Signed-off-by: Juan Cruz Viotti <jv@jviotti.com>
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
🤖 Augment PR SummarySummary: This PR updates the vendored Changes:
Technical Notes: 🤖 Was this summary useful? React with 👍 or 👎 |
![augmentcode[bot]](https://avatars.githubusercontent.com/in/1027498?s=60&v=4){kind=small}
| return std::nullopt; | ||
| } | ||
|
|
||
| assert(vocabulary_entry->is_object()); |
There was a problem hiding this comment.
vendor/core/src/core/jsonschema/jsonschema.cc:467: Relying on assert(vocabulary_entry->is_object()) means a non-object $vocabulary can lead to crashes/UB in release builds when as_object() is called. Consider handling invalid $vocabulary shapes and non-boolean entries (see line 470) by returning nullopt rather than depending on assert for input validation.
Severity: high
Other Locations
vendor/core/src/core/jsonschema/jsonschema.cc:470
🤖 Was this useful? React with 👍 or 👎, or 🚀 if it prevented an incident/outage.
| const JSON::String base_key{reference_base}; | ||
|
|
||
| // Check the resolver cache to avoid redundant lookups | ||
| const auto cached{this->resolver_cache_.find(base_key)}; |
There was a problem hiding this comment.
vendor/core/src/extension/alterschema/linter/invalid_external_ref.h:54: resolver_cache_/frame_cache_ persist on the rule instance, but SchemaTransformer can be reused across check/apply calls (potentially with different SchemaResolvers), so cached resolution failures/successes may become stale and produce incorrect lint results. Also, frame_cache_ is keyed only by base_key even though the frame is built using location.dialect (line 103), which could be wrong if the same remote base is referenced under different dialect contexts.
Severity: medium
🤖 Was this useful? React with 👍 or 👎, or 🚀 if it prevented an incident/outage.
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Benchmark (linux/llvm)
Details
| Benchmark suite | Current: 909de79 | Previous: 19fd006 | Ratio |
|---|---|---|---|
E2E_Compiler_adaptivecard |
64192669.000004806 ns/iter |
64139483.70000072 ns/iter |
1.00 |
E2E_Compiler_ansible_meta |
29114309.29166651 ns/iter |
28912969.70833442 ns/iter |
1.01 |
E2E_Compiler_aws_cdk |
378228.07908992487 ns/iter |
380461.38356910134 ns/iter |
0.99 |
E2E_Compiler_babelrc |
2590213.6494465084 ns/iter |
2581021.771217612 ns/iter |
1.00 |
E2E_Compiler_clang_format |
18430150.421053033 ns/iter |
18343144.289474368 ns/iter |
1.00 |
E2E_Compiler_cmake_presets |
25874573.33333355 ns/iter |
25995775.48148057 ns/iter |
1.00 |
E2E_Compiler_code_climate |
2590628.681481475 ns/iter |
2574728.974264715 ns/iter |
1.01 |
E2E_Compiler_cql2 |
12934012.759259345 ns/iter |
12819281.31481575 ns/iter |
1.01 |
E2E_Compiler_cspell |
23050959.76666583 ns/iter |
22665498.548387714 ns/iter |
1.02 |
E2E_Compiler_cypress |
3958992.593220243 ns/iter |
3911855.0837988122 ns/iter |
1.01 |
E2E_Compiler_deno |
7833510.269662884 ns/iter |
7828607.175824075 ns/iter |
1.00 |
E2E_Compiler_dependabot |
3922587.9273743494 ns/iter |
3897176.2793294806 ns/iter |
1.01 |
E2E_Compiler_draft_04 |
2711553.9382240605 ns/iter |
2688315.5938696614 ns/iter |
1.01 |
E2E_Compiler_fabric_mod |
4779612.142857133 ns/iter |
4740380.088435746 ns/iter |
1.01 |
E2E_Compiler_geojson |
22336011.483869903 ns/iter |
22080239.656251166 ns/iter |
1.01 |
E2E_Compiler_gitpod_configuration |
4947959.821428834 ns/iter |
4908023.570422615 ns/iter |
1.01 |
E2E_Compiler_helm_chart_lock |
711284.1597151275 ns/iter |
709008.0040816641 ns/iter |
1.00 |
E2E_Compiler_importmap |
287190.88939143624 ns/iter |
286894.3893223972 ns/iter |
1.00 |
E2E_Compiler_jasmine |
1372114.3933463877 ns/iter |
1363919.1031128443 ns/iter |
1.01 |
E2E_Compiler_jshintrc |
4391367.602484547 ns/iter |
4350293.32919259 ns/iter |
1.01 |
E2E_Compiler_jsconfig |
22010672.312500644 ns/iter |
21669126.15625094 ns/iter |
1.02 |
E2E_Compiler_krakend |
142756149.59999532 ns/iter |
137410612.4000036 ns/iter |
1.04 |
E2E_Compiler_lazygit |
33585325.42857315 ns/iter |
33288594.619047478 ns/iter |
1.01 |
E2E_Compiler_lerna |
1594177.6036447352 ns/iter |
1594949.584090893 ns/iter |
1.00 |
E2E_Compiler_nest_cli |
7501636.462365318 ns/iter |
7438629.765957519 ns/iter |
1.01 |
E2E_Compiler_omc |
158636347.2499954 ns/iter |
152670897.99999666 ns/iter |
1.04 |
E2E_Compiler_omnisharp |
6740855.394230476 ns/iter |
6722010.115384391 ns/iter |
1.00 |
E2E_Compiler_openapi |
25063630.142856903 ns/iter |
24859341.39285665 ns/iter |
1.01 |
E2E_Compiler_pre_commit_hooks |
5356237.338461895 ns/iter |
5315391.534351271 ns/iter |
1.01 |
E2E_Compiler_pulumi |
4061588.375722586 ns/iter |
4039556.1329479557 ns/iter |
1.01 |
E2E_Compiler_semantic_release |
1581309.0203619602 ns/iter |
1572556.0382883167 ns/iter |
1.01 |
E2E_Compiler_stale |
1564753.5659954587 ns/iter |
1562821.4142538216 ns/iter |
1.00 |
E2E_Compiler_stylecop |
6229874.1250000745 ns/iter |
6146945.640350902 ns/iter |
1.01 |
E2E_Compiler_tmuxinator |
1939187.524999871 ns/iter |
1931361.06336094 ns/iter |
1.00 |
E2E_Compiler_ui5 |
47697276.66666768 ns/iter |
46911395.20000055 ns/iter |
1.02 |
E2E_Compiler_ui5_manifest |
318629727.4999958 ns/iter |
306498261.00000155 ns/iter |
1.04 |
E2E_Compiler_unreal_engine_uproject |
4608581.046357551 ns/iter |
4590551.875000191 ns/iter |
1.00 |
E2E_Compiler_vercel |
12623646.69642884 ns/iter |
12403112.660714602 ns/iter |
1.02 |
E2E_Compiler_yamllint |
351374.42126380536 ns/iter |
351982.17830236803 ns/iter |
1.00 |
E2E_Evaluator_adaptivecard |
28252.835018149122 ns/iter |
25219.75842208371 ns/iter |
1.12 |
E2E_Evaluator_ansible_meta |
241818.4692334164 ns/iter |
234896.29335116895 ns/iter |
1.03 |
E2E_Evaluator_aws_cdk |
52137.44050688963 ns/iter |
51498.339210368125 ns/iter |
1.01 |
E2E_Evaluator_babelrc |
110298.84079836543 ns/iter |
107297.41404209091 ns/iter |
1.03 |
E2E_Evaluator_cerebrum_criminal_case |
1240506.4254545034 ns/iter |
1236204.125886494 ns/iter |
1.00 |
E2E_Evaluator_clang_format |
125274.85152916686 ns/iter |
123892.63612194317 ns/iter |
1.01 |
E2E_Evaluator_cmake_presets |
4322869.834355693 ns/iter |
4199758.419161811 ns/iter |
1.03 |
E2E_Evaluator_code_climate |
179716.05998462037 ns/iter |
177730.86717751436 ns/iter |
1.01 |
E2E_Evaluator_cql2 |
220536.46455223777 ns/iter |
207295.059653255 ns/iter |
1.06 |
E2E_Evaluator_cspell |
569814.448812479 ns/iter |
565742.3164251212 ns/iter |
1.01 |
E2E_Evaluator_cypress |
191726.05730028526 ns/iter |
191375.94346871524 ns/iter |
1.00 |
E2E_Evaluator_deno |
316543.5705272571 ns/iter |
320490.15829941246 ns/iter |
0.99 |
E2E_Evaluator_dependabot |
430461.7470912396 ns/iter |
427582.30012151785 ns/iter |
1.01 |
E2E_Evaluator_draft_04 |
7423348.344444018 ns/iter |
7035575.5876291655 ns/iter |
1.06 |
E2E_Evaluator_fabric_mod |
693349.7482656298 ns/iter |
695555.1606268431 ns/iter |
1.00 |
E2E_Evaluator_geojson |
15253685.55555436 ns/iter |
15154976.913043296 ns/iter |
1.01 |
E2E_Evaluator_gitpod_configuration |
233911.29314420652 ns/iter |
232425.06239628285 ns/iter |
1.01 |
E2E_Evaluator_helm_chart_lock |
358608.61632653145 ns/iter |
351938.11305654806 ns/iter |
1.02 |
E2E_Evaluator_importmap |
49688.11305305126 ns/iter |
47492.13079970458 ns/iter |
1.05 |
E2E_Evaluator_jasmine |
107923.79511449258 ns/iter |
108059.09670028006 ns/iter |
1.00 |
E2E_Evaluator_jshintrc |
1229903.968365595 ns/iter |
1212003.6003460044 ns/iter |
1.01 |
E2E_Evaluator_jsconfig |
432037.11206373625 ns/iter |
430091.13349663944 ns/iter |
1.00 |
E2E_Evaluator_krakend |
213988.33018005567 ns/iter |
213217.3751900302 ns/iter |
1.00 |
E2E_Evaluator_lazygit |
148200.01785334677 ns/iter |
145779.17550766695 ns/iter |
1.02 |
E2E_Evaluator_lerna |
145636.4687629351 ns/iter |
149130.37932489067 ns/iter |
0.98 |
E2E_Evaluator_nest_cli |
184796.87792552594 ns/iter |
183051.1073667709 ns/iter |
1.01 |
E2E_Evaluator_omc |
21237.528445344695 ns/iter |
20781.15714535779 ns/iter |
1.02 |
E2E_Evaluator_omnisharp |
605851.5469565305 ns/iter |
602990.0592274952 ns/iter |
1.00 |
E2E_Evaluator_openapi |
14876515.239998298 ns/iter |
12881874.057692008 ns/iter |
1.15 |
E2E_Evaluator_pre_commit_hooks |
481178.2683264071 ns/iter |
490780.00136893167 ns/iter |
0.98 |
E2E_Evaluator_pulumi |
704493.256770344 ns/iter |
696038.0640495106 ns/iter |
1.01 |
E2E_Evaluator_semantic_release |
99988.95246801728 ns/iter |
98356.37847270924 ns/iter |
1.02 |
E2E_Evaluator_stale |
155089.2068579131 ns/iter |
154306.3022479196 ns/iter |
1.01 |
E2E_Evaluator_stylecop |
289875.04489291616 ns/iter |
283008.8124243949 ns/iter |
1.02 |
E2E_Evaluator_tmuxinator |
99271.62949230275 ns/iter |
99221.24452035328 ns/iter |
1.00 |
E2E_Evaluator_ui5 |
534186.3655749923 ns/iter |
514121.9255474724 ns/iter |
1.04 |
E2E_Evaluator_ui5_manifest |
2594969.1310859476 ns/iter |
2549052.044444293 ns/iter |
1.02 |
E2E_Evaluator_unreal_engine_uproject |
423995.5784373058 ns/iter |
426212.00912405446 ns/iter |
0.99 |
E2E_Evaluator_vercel |
329661.45658263506 ns/iter |
326994.72483837744 ns/iter |
1.01 |
E2E_Evaluator_yamllint |
9006.241680355042 ns/iter |
8723.10797990431 ns/iter |
1.03 |
Micro_Draft4_Meta_1_No_Callback |
196.37282253395375 ns/iter |
183.80998159383952 ns/iter |
1.07 |
Micro_Draft4_Required_Properties |
860.8545939380938 ns/iter |
867.4289614548002 ns/iter |
0.99 |
Micro_Draft4_Many_Optional_Properties_Minimal_Match |
22.82782897464533 ns/iter |
22.803382332417055 ns/iter |
1.00 |
Micro_Draft4_Few_Optional_Properties_Minimal_Match |
11.52587587180593 ns/iter |
11.523231033027079 ns/iter |
1.00 |
Micro_Draft4_Items_Schema |
287.82051732165996 ns/iter |
291.4056775515349 ns/iter |
0.99 |
Micro_Draft4_Nested_Object |
1.771174028314459 ns/iter |
1.772976314744318 ns/iter |
1.00 |
Micro_Draft4_Properties_Triad_Optional |
329.37228966102236 ns/iter |
334.4468605860699 ns/iter |
0.98 |
Micro_Draft4_Properties_Triad_Closed |
271.05286105629585 ns/iter |
275.1717373792139 ns/iter |
0.99 |
Micro_Draft4_Properties_Triad_Required |
352.87864070025444 ns/iter |
356.36185847235504 ns/iter |
0.99 |
Micro_Draft4_Properties_Closed |
57.99699727957295 ns/iter |
57.987616506012536 ns/iter |
1.00 |
Micro_Draft4_Non_Recursive_Ref |
12.057292068627703 ns/iter |
11.965744773853551 ns/iter |
1.01 |
Micro_Draft4_Pattern_Properties_True |
191.55902521070996 ns/iter |
188.3267628230041 ns/iter |
1.02 |
Micro_Draft4_Ref_To_Single_Property |
11.52429994774117 ns/iter |
11.52624339675839 ns/iter |
1.00 |
Micro_Draft4_Additional_Properties_Type |
21.771726323108155 ns/iter |
21.66809666164152 ns/iter |
1.00 |
Micro_Draft4_Nested_Oneof |
56.342971995095716 ns/iter |
56.356791209314075 ns/iter |
1.00 |
Micro_Draft4_Short_Enum |
14.00801498239487 ns/iter |
14.017529108285636 ns/iter |
1.00 |
Micro_Draft4_Long_Enum |
14.653452090197174 ns/iter |
14.3490218581436 ns/iter |
1.02 |
Micro_Draft4_Long_Enum_Short_Strings |
14.008828864154408 ns/iter |
14.069712508418025 ns/iter |
1.00 |
Micro_Draft4_Type_Object |
3.4247559693097043 ns/iter |
3.4279109065223112 ns/iter |
1.00 |
Micro_Draft4_Ref_Single_100 |
2388078.561224432 ns/iter |
2387613.5767916455 ns/iter |
1.00 |
Micro_Draft4_Compile_Ref_Many_Nested |
1723798.48029569 ns/iter |
1727644.346437419 ns/iter |
1.00 |
Micro_Draft4_Compile_Wrap |
2403465.711340202 ns/iter |
2390833.48805471 ns/iter |
1.01 |
Micro_Draft6_Property_Names |
116.41706310076965 ns/iter |
110.52769041873388 ns/iter |
1.05 |
Micro_Draft6_Compile_FHIR |
13775895998.00001 ns/iter |
13958885205.000002 ns/iter |
0.99 |
Micro_Draft7_If_Then_Else |
23.978857569800162 ns/iter |
23.991183010095888 ns/iter |
1.00 |
Micro_2019_09_Unevaluated_Properties |
29.3274755994618 ns/iter |
29.304952453817943 ns/iter |
1.00 |
Micro_2019_09_Compile_Wrap |
298557974.9999943 ns/iter |
294259509.0000282 ns/iter |
1.01 |
Micro_2019_09_KrakenD_Linter_Check |
1163930884.000024 ns/iter |
1169803842.9999542 ns/iter |
0.99 |
Micro_2019_09_KrakenD_Linter_Apply |
10402961105.00003 ns/iter |
10366628864.000177 ns/iter |
1.00 |
Micro_2020_12_Dynamic_Ref |
233.1205603804427 ns/iter |
233.15447782710697 ns/iter |
1.00 |
Micro_2020_12_Dynamic_Ref_Single |
3.423292876843643 ns/iter |
3.424579066865174 ns/iter |
1.00 |
Micro_2020_12_Simple_Output_Mask |
75668.82949009047 ns/iter |
77745.56355653258 ns/iter |
0.97 |
Micro_2020_12_Simple_Output_Annotations |
140460.99499300116 ns/iter |
138796.71300894374 ns/iter |
1.01 |
Micro_2020_12_Compile_NonCircular_Shared_Refs |
1099389.7084639696 ns/iter |
1104050.5063290398 ns/iter |
1.00 |
Micro_2020_12_Exhaustive_Deep_Numeric |
8102.199892699121 ns/iter |
8130.310927796648 ns/iter |
1.00 |
Micro_2020_12_Exhaustive_Deep_Numeric_SimpleOutput |
186033.99029380415 ns/iter |
177525.44021326982 ns/iter |
1.05 |
Micro_2020_12_Exhaustive_Deep_Numeric_TraceOutput |
22335.752600011947 ns/iter |
22406.308351592474 ns/iter |
1.00 |
Micro_2020_12_Exhaustive_Deep_Numeric_Fail |
148.8071270878758 ns/iter |
143.63646570421866 ns/iter |
1.04 |
Micro_2020_12_Exhaustive_Deep_Numeric_Fail_SimpleOutput |
4747.123293869111 ns/iter |
4786.040194073332 ns/iter |
0.99 |
This comment was automatically generated by workflow using github-action-benchmark.
There was a problem hiding this comment.
Benchmark (macos/llvm)
Details
| Benchmark suite | Current: 909de79 | Previous: 19fd006 | Ratio |
|---|---|---|---|
E2E_Compiler_adaptivecard |
62342675.888885416 ns/iter |
56300881.916664965 ns/iter |
1.11 |
E2E_Compiler_ansible_meta |
27526133.928566717 ns/iter |
24572044.55172673 ns/iter |
1.12 |
E2E_Compiler_aws_cdk |
315656.4732143303 ns/iter |
261191.61424882585 ns/iter |
1.21 |
E2E_Compiler_babelrc |
2220998.1564638116 ns/iter |
2030956.88081391 ns/iter |
1.09 |
E2E_Compiler_clang_format |
15107398.063835409 ns/iter |
13992681.979590664 ns/iter |
1.08 |
E2E_Compiler_cmake_presets |
26000351.679995216 ns/iter |
23455109.69999699 ns/iter |
1.11 |
E2E_Compiler_code_climate |
2308386.3112583305 ns/iter |
2053576.223529356 ns/iter |
1.12 |
E2E_Compiler_cql2 |
11767231.770827873 ns/iter |
10882448.242424207 ns/iter |
1.08 |
E2E_Compiler_cspell |
21085203.722224023 ns/iter |
18764802.371424593 ns/iter |
1.12 |
E2E_Compiler_cypress |
4549638.074468505 ns/iter |
3334379.3051641677 ns/iter |
1.36 |
E2E_Compiler_deno |
10930431.29729857 ns/iter |
6452424.415928628 ns/iter |
1.69 |
E2E_Compiler_dependabot |
4141058.566432917 ns/iter |
3421899.409091804 ns/iter |
1.21 |
E2E_Compiler_draft_04 |
2176993.362712183 ns/iter |
1860301.861702307 ns/iter |
1.17 |
E2E_Compiler_fabric_mod |
4343047.036810203 ns/iter |
3448004.3316825056 ns/iter |
1.26 |
E2E_Compiler_geojson |
24819346.714285273 ns/iter |
20369226.171429288 ns/iter |
1.22 |
E2E_Compiler_gitpod_configuration |
5303640.420002012 ns/iter |
3834393.543956549 ns/iter |
1.38 |
E2E_Compiler_helm_chart_lock |
700955.4573100987 ns/iter |
494505.6298381505 ns/iter |
1.42 |
E2E_Compiler_importmap |
235878.16660569556 ns/iter |
212943.26976225464 ns/iter |
1.11 |
E2E_Compiler_jasmine |
1161433.9101122804 ns/iter |
1082089.908953181 ns/iter |
1.07 |
E2E_Compiler_jshintrc |
3379675.1207716805 ns/iter |
2995030.9288890115 ns/iter |
1.13 |
E2E_Compiler_jsconfig |
23472253.676466018 ns/iter |
17416415.58974385 ns/iter |
1.35 |
E2E_Compiler_krakend |
143298616.5999864 ns/iter |
121983465.33333886 ns/iter |
1.17 |
E2E_Compiler_lazygit |
42288593.75000411 ns/iter |
29448065.958339006 ns/iter |
1.44 |
E2E_Compiler_lerna |
1857956.5863875593 ns/iter |
1244034.3392539439 ns/iter |
1.49 |
E2E_Compiler_nest_cli |
6566626.9809515225 ns/iter |
5813183.4017101815 ns/iter |
1.13 |
E2E_Compiler_omc |
193404972.33330703 ns/iter |
141805974.99998838 ns/iter |
1.36 |
E2E_Compiler_omnisharp |
7286019.510637686 ns/iter |
5526423.228345058 ns/iter |
1.32 |
E2E_Compiler_openapi |
23147128.608699225 ns/iter |
19813194.0285683 ns/iter |
1.17 |
E2E_Compiler_pre_commit_hooks |
4734788.688314107 ns/iter |
3889260.585636052 ns/iter |
1.22 |
E2E_Compiler_pulumi |
3806051.2836531973 ns/iter |
3038391.631578538 ns/iter |
1.25 |
E2E_Compiler_semantic_release |
1242592.6103644643 ns/iter |
1225256.188255448 ns/iter |
1.01 |
E2E_Compiler_stale |
1559231.4257026513 ns/iter |
1168924.7933886203 ns/iter |
1.33 |
E2E_Compiler_stylecop |
5695535.38095519 ns/iter |
5142682.065217042 ns/iter |
1.11 |
E2E_Compiler_tmuxinator |
1590622.5825891139 ns/iter |
1492673.9327729363 ns/iter |
1.07 |
E2E_Compiler_ui5 |
53966194.50001102 ns/iter |
44712375.00000314 ns/iter |
1.21 |
E2E_Compiler_ui5_manifest |
398486437.4999688 ns/iter |
253185180.66668126 ns/iter |
1.57 |
E2E_Compiler_unreal_engine_uproject |
3925659.558821922 ns/iter |
3470901.8750004363 ns/iter |
1.13 |
E2E_Compiler_vercel |
12417076.642853837 ns/iter |
11355620.833330704 ns/iter |
1.09 |
E2E_Compiler_yamllint |
255906.3685368524 ns/iter |
234035.09733331398 ns/iter |
1.09 |
E2E_Evaluator_adaptivecard |
19320.134532266144 ns/iter |
17266.660690912588 ns/iter |
1.12 |
E2E_Evaluator_ansible_meta |
160955.65032081376 ns/iter |
153316.10141207077 ns/iter |
1.05 |
E2E_Evaluator_aws_cdk |
33344.81129875139 ns/iter |
30594.359316013666 ns/iter |
1.09 |
E2E_Evaluator_babelrc |
81807.50450051781 ns/iter |
74765.68191950787 ns/iter |
1.09 |
E2E_Evaluator_cerebrum_criminal_case |
881288.8958593495 ns/iter |
828205.7352942181 ns/iter |
1.06 |
E2E_Evaluator_clang_format |
97072.14707497547 ns/iter |
90841.38527259132 ns/iter |
1.07 |
E2E_Evaluator_cmake_presets |
3524688.333333567 ns/iter |
2896066.9642858403 ns/iter |
1.22 |
E2E_Evaluator_code_climate |
119982.06762613222 ns/iter |
111569.13032866006 ns/iter |
1.08 |
E2E_Evaluator_cql2 |
146002.769461011 ns/iter |
136988.5390307011 ns/iter |
1.07 |
E2E_Evaluator_cspell |
387063.2512478372 ns/iter |
347767.4985178102 ns/iter |
1.11 |
E2E_Evaluator_cypress |
140559.0250988817 ns/iter |
126804.92293840362 ns/iter |
1.11 |
E2E_Evaluator_deno |
253631.5565771249 ns/iter |
199768.14101085602 ns/iter |
1.27 |
E2E_Evaluator_dependabot |
304102.1253311243 ns/iter |
283690.0191993747 ns/iter |
1.07 |
E2E_Evaluator_draft_04 |
5016632.735714666 ns/iter |
4627526.992958914 ns/iter |
1.08 |
E2E_Evaluator_fabric_mod |
500306.0206185264 ns/iter |
430207.4876998241 ns/iter |
1.16 |
E2E_Evaluator_geojson |
14196919.393442407 ns/iter |
10182608.928572075 ns/iter |
1.39 |
E2E_Evaluator_gitpod_configuration |
170780.17058970744 ns/iter |
146939.0415518264 ns/iter |
1.16 |
E2E_Evaluator_helm_chart_lock |
238526.35090063888 ns/iter |
190950.99831269606 ns/iter |
1.25 |
E2E_Evaluator_importmap |
32282.425295281188 ns/iter |
27429.552613732598 ns/iter |
1.18 |
E2E_Evaluator_jasmine |
89525.65252772822 ns/iter |
74091.26144606603 ns/iter |
1.21 |
E2E_Evaluator_jshintrc |
1233704.5822790966 ns/iter |
850891.2609757805 ns/iter |
1.45 |
E2E_Evaluator_jsconfig |
327594.0371831509 ns/iter |
280123.2988506537 ns/iter |
1.17 |
E2E_Evaluator_krakend |
197345.30727762153 ns/iter |
121101.5219236065 ns/iter |
1.63 |
E2E_Evaluator_lazygit |
118274.85540600709 ns/iter |
84741.04819566148 ns/iter |
1.40 |
E2E_Evaluator_lerna |
129994.92968418435 ns/iter |
107371.31927250141 ns/iter |
1.21 |
E2E_Evaluator_nest_cli |
136681.318233769 ns/iter |
114879.20916301732 ns/iter |
1.19 |
E2E_Evaluator_omc |
16258.316738043051 ns/iter |
13480.396965695229 ns/iter |
1.21 |
E2E_Evaluator_omnisharp |
490399.37292825384 ns/iter |
395554.9317793857 ns/iter |
1.24 |
E2E_Evaluator_openapi |
9322597.385545965 ns/iter |
7484602.011494456 ns/iter |
1.25 |
E2E_Evaluator_pre_commit_hooks |
375650.11524155474 ns/iter |
307026.78410592367 ns/iter |
1.22 |
E2E_Evaluator_pulumi |
553373.9618380922 ns/iter |
483386.67454065447 ns/iter |
1.14 |
E2E_Evaluator_semantic_release |
75983.93698689627 ns/iter |
64744.70142310319 ns/iter |
1.17 |
E2E_Evaluator_stale |
125132.91052910793 ns/iter |
102366.7185550421 ns/iter |
1.22 |
E2E_Evaluator_stylecop |
267598.1465266163 ns/iter |
168224.13661730482 ns/iter |
1.59 |
E2E_Evaluator_tmuxinator |
77873.78271494081 ns/iter |
63484.7809203927 ns/iter |
1.23 |
E2E_Evaluator_ui5 |
379064.9219590176 ns/iter |
309325.5229885168 ns/iter |
1.23 |
E2E_Evaluator_ui5_manifest |
1952793.8352597095 ns/iter |
1503277.2845192251 ns/iter |
1.30 |
E2E_Evaluator_unreal_engine_uproject |
339888.2605670142 ns/iter |
287732.61019740393 ns/iter |
1.18 |
E2E_Evaluator_vercel |
249825.80421046328 ns/iter |
209974.77903078514 ns/iter |
1.19 |
E2E_Evaluator_yamllint |
6567.014419122083 ns/iter |
5596.609403241332 ns/iter |
1.17 |
Micro_Draft4_Meta_1_No_Callback |
140.05299205836963 ns/iter |
122.82894952569929 ns/iter |
1.14 |
Micro_Draft4_Required_Properties |
765.7984297553455 ns/iter |
591.8363117556476 ns/iter |
1.29 |
Micro_Draft4_Many_Optional_Properties_Minimal_Match |
23.03714461800824 ns/iter |
17.17880456368775 ns/iter |
1.34 |
Micro_Draft4_Few_Optional_Properties_Minimal_Match |
8.05765615758945 ns/iter |
6.711233201792633 ns/iter |
1.20 |
Micro_Draft4_Items_Schema |
282.6937917568843 ns/iter |
243.35243817900783 ns/iter |
1.16 |
Micro_Draft4_Nested_Object |
0.7659296192127304 ns/iter |
0.6449620730283646 ns/iter |
1.19 |
Micro_Draft4_Properties_Triad_Optional |
222.0361266259478 ns/iter |
193.1142811515638 ns/iter |
1.15 |
Micro_Draft4_Properties_Triad_Closed |
185.13500652278415 ns/iter |
155.94753556647717 ns/iter |
1.19 |
Micro_Draft4_Properties_Triad_Required |
235.60676821371527 ns/iter |
197.1498978203764 ns/iter |
1.20 |
Micro_Draft4_Properties_Closed |
47.51908029475343 ns/iter |
35.08920901665281 ns/iter |
1.35 |
Micro_Draft4_Non_Recursive_Ref |
14.631770398457762 ns/iter |
12.171339026883462 ns/iter |
1.20 |
Micro_Draft4_Pattern_Properties_True |
153.3376791099591 ns/iter |
130.95949949510228 ns/iter |
1.17 |
Micro_Draft4_Ref_To_Single_Property |
7.671428021508768 ns/iter |
6.7556868559696825 ns/iter |
1.14 |
Micro_Draft4_Additional_Properties_Type |
27.51323634060145 ns/iter |
23.80538372351204 ns/iter |
1.16 |
Micro_Draft4_Nested_Oneof |
45.380141152353765 ns/iter |
38.21374371428956 ns/iter |
1.19 |
Micro_Draft4_Short_Enum |
5.593971486678266 ns/iter |
4.706797557467216 ns/iter |
1.19 |
Micro_Draft4_Long_Enum |
10.952564778547977 ns/iter |
9.527693139718522 ns/iter |
1.15 |
Micro_Draft4_Long_Enum_Short_Strings |
7.109330320014429 ns/iter |
6.0745273821412455 ns/iter |
1.17 |
Micro_Draft4_Type_Object |
2.427007997852794 ns/iter |
2.1436553872601025 ns/iter |
1.13 |
Micro_Draft4_Ref_Single_100 |
1936454.4797688175 ns/iter |
1653375.9124091275 ns/iter |
1.17 |
Micro_Draft4_Compile_Ref_Many_Nested |
1433275.727650386 ns/iter |
1156680.4429969618 ns/iter |
1.24 |
Micro_Draft4_Compile_Wrap |
2603100.1354846423 ns/iter |
1977911.9475136097 ns/iter |
1.32 |
Micro_Draft6_Property_Names |
109.86876784525506 ns/iter |
88.9237873731017 ns/iter |
1.24 |
Micro_Draft6_Compile_FHIR |
12682394333.000048 ns/iter |
7330117541.999926 ns/iter |
1.73 |
Micro_Draft7_If_Then_Else |
19.04877118862654 ns/iter |
15.998520754781214 ns/iter |
1.19 |
Micro_2019_09_Unevaluated_Properties |
28.39075546807879 ns/iter |
24.170511653092323 ns/iter |
1.17 |
Micro_2019_09_Compile_Wrap |
404182562.49995464 ns/iter |
303244917.0000291 ns/iter |
1.33 |
Micro_2019_09_KrakenD_Linter_Check |
784512875.0000186 ns/iter |
567250124.9998732 ns/iter |
1.38 |
Micro_2019_09_KrakenD_Linter_Apply |
7335336790.999918 ns/iter |
5210041875.999877 ns/iter |
1.41 |
Micro_2020_12_Dynamic_Ref |
202.56758908265854 ns/iter |
175.329980163105 ns/iter |
1.16 |
Micro_2020_12_Dynamic_Ref_Single |
2.4193978830398617 ns/iter |
2.0397091397361864 ns/iter |
1.19 |
Micro_2020_12_Simple_Output_Mask |
78085.82962137784 ns/iter |
64510.669456072945 ns/iter |
1.21 |
Micro_2020_12_Simple_Output_Annotations |
128008.67832934744 ns/iter |
107631.51596070924 ns/iter |
1.19 |
Micro_2020_12_Compile_NonCircular_Shared_Refs |
934592.1495959327 ns/iter |
779861.4553349572 ns/iter |
1.20 |
Micro_2020_12_Exhaustive_Deep_Numeric |
5778.48694166706 ns/iter |
5804.334057645147 ns/iter |
1.00 |
Micro_2020_12_Exhaustive_Deep_Numeric_SimpleOutput |
128534.30456571296 ns/iter |
109621.37019532603 ns/iter |
1.17 |
Micro_2020_12_Exhaustive_Deep_Numeric_TraceOutput |
15924.699278741935 ns/iter |
16532.902861893534 ns/iter |
0.96 |
Micro_2020_12_Exhaustive_Deep_Numeric_Fail |
101.93951031951771 ns/iter |
87.17818655310354 ns/iter |
1.17 |
Micro_2020_12_Exhaustive_Deep_Numeric_Fail_SimpleOutput |
6762.613083554662 ns/iter |
4469.889594097941 ns/iter |
1.51 |
This comment was automatically generated by workflow using github-action-benchmark.
There was a problem hiding this comment.
Benchmark (linux/gcc)
Details
| Benchmark suite | Current: 909de79 | Previous: a80761a | Ratio |
|---|---|---|---|
Micro_2020_12_Dynamic_Ref |
258.14002386627135 ns/iter |
271.11211138924915 ns/iter |
0.95 |
Micro_2020_12_Dynamic_Ref_Single |
4.980684305342695 ns/iter |
4.221451605019714 ns/iter |
1.18 |
Micro_2020_12_Simple_Output_Mask |
84801.70365927214 ns/iter |
80236.7587859519 ns/iter |
1.06 |
Micro_2020_12_Simple_Output_Annotations |
150060.27481247642 ns/iter |
138714.0857142645 ns/iter |
1.08 |
Micro_2020_12_Compile_NonCircular_Shared_Refs |
1220750.127399292 ns/iter |
1210280.932525817 ns/iter |
1.01 |
Micro_2020_12_Exhaustive_Deep_Numeric |
8372.471246083793 ns/iter |
8020.7127684728175 ns/iter |
1.04 |
Micro_2020_12_Exhaustive_Deep_Numeric_SimpleOutput |
169248.2972777466 ns/iter |
169576.44433686513 ns/iter |
1.00 |
Micro_2020_12_Exhaustive_Deep_Numeric_TraceOutput |
26046.16000148854 ns/iter |
26908.882606329673 ns/iter |
0.97 |
Micro_2020_12_Exhaustive_Deep_Numeric_Fail |
126.97461481467941 ns/iter |
132.48716106020078 ns/iter |
0.96 |
Micro_2020_12_Exhaustive_Deep_Numeric_Fail_SimpleOutput |
5216.729720143205 ns/iter |
4977.8974171071495 ns/iter |
1.05 |
Micro_2019_09_Unevaluated_Properties |
31.16197006481845 ns/iter |
30.279501860348315 ns/iter |
1.03 |
Micro_2019_09_Compile_Wrap |
312179769.4999486 ns/iter |
332498144.49993664 ns/iter |
0.94 |
Micro_2019_09_KrakenD_Linter_Check |
1259893521.0000947 ns/iter |
1333393959.9999666 ns/iter |
0.94 |
Micro_2019_09_KrakenD_Linter_Apply |
10986025093.00008 ns/iter |
11859183889.99994 ns/iter |
0.93 |
Micro_Draft7_If_Then_Else |
25.559363356967413 ns/iter |
26.21414623722157 ns/iter |
0.98 |
Micro_Draft6_Property_Names |
142.61252561179495 ns/iter |
142.55102634567083 ns/iter |
1.00 |
Micro_Draft6_Compile_FHIR |
14093825279.99992 ns/iter |
15233548423.000002 ns/iter |
0.93 |
Micro_Draft4_Meta_1_No_Callback |
171.42390726301772 ns/iter |
172.6167658431835 ns/iter |
0.99 |
Micro_Draft4_Required_Properties |
811.6803825938653 ns/iter |
813.2720235562277 ns/iter |
1.00 |
Micro_Draft4_Many_Optional_Properties_Minimal_Match |
21.522034556681714 ns/iter |
21.283132161578852 ns/iter |
1.01 |
Micro_Draft4_Few_Optional_Properties_Minimal_Match |
13.406823832260455 ns/iter |
13.03953003028004 ns/iter |
1.03 |
Micro_Draft4_Items_Schema |
402.37963166270094 ns/iter |
315.9837308255626 ns/iter |
1.27 |
Micro_Draft4_Nested_Object |
1.8699674614937527 ns/iter |
2.1115330712985187 ns/iter |
0.89 |
Micro_Draft4_Properties_Triad_Optional |
505.4202420001275 ns/iter |
440.8841694398102 ns/iter |
1.15 |
Micro_Draft4_Properties_Triad_Closed |
392.25815077905224 ns/iter |
354.4087880967835 ns/iter |
1.11 |
Micro_Draft4_Properties_Triad_Required |
489.89878795414603 ns/iter |
466.8129917024976 ns/iter |
1.05 |
Micro_Draft4_Properties_Closed |
62.98756053716744 ns/iter |
62.412171697548935 ns/iter |
1.01 |
Micro_Draft4_Non_Recursive_Ref |
9.66802700170751 ns/iter |
9.361395525699583 ns/iter |
1.03 |
Micro_Draft4_Pattern_Properties_True |
238.58769481620317 ns/iter |
203.2266722386355 ns/iter |
1.17 |
Micro_Draft4_Ref_To_Single_Property |
13.416745363591557 ns/iter |
13.013229316326312 ns/iter |
1.03 |
Micro_Draft4_Additional_Properties_Type |
14.634763356562704 ns/iter |
14.905008708396789 ns/iter |
0.98 |
Micro_Draft4_Nested_Oneof |
66.96112001299045 ns/iter |
66.14818774518858 ns/iter |
1.01 |
Micro_Draft4_Short_Enum |
14.67678839124977 ns/iter |
14.816027876925027 ns/iter |
0.99 |
Micro_Draft4_Long_Enum |
14.960019498871295 ns/iter |
13.379819587575687 ns/iter |
1.12 |
Micro_Draft4_Long_Enum_Short_Strings |
14.721350675216279 ns/iter |
14.813521980375908 ns/iter |
0.99 |
Micro_Draft4_Type_Object |
4.982298725117109 ns/iter |
4.220911363969132 ns/iter |
1.18 |
Micro_Draft4_Ref_Single_100 |
2520308.054151727 ns/iter |
2517401.014388564 ns/iter |
1.00 |
Micro_Draft4_Compile_Ref_Many_Nested |
1832041.76041644 ns/iter |
1831205.6151833541 ns/iter |
1.00 |
Micro_Draft4_Compile_Wrap |
2605753.7657998456 ns/iter |
2605630.1492537805 ns/iter |
1.00 |
E2E_Compiler_adaptivecard |
66468918.299983665 ns/iter |
71093857.40000108 ns/iter |
0.93 |
E2E_Compiler_ansible_meta |
30984605.608696457 ns/iter |
31659885.045449052 ns/iter |
0.98 |
E2E_Compiler_aws_cdk |
414143.349675181 ns/iter |
402428.74541288026 ns/iter |
1.03 |
E2E_Compiler_babelrc |
2804329.540000254 ns/iter |
2821080.1048383093 ns/iter |
0.99 |
E2E_Compiler_clang_format |
19839613.828571603 ns/iter |
20043377.97142658 ns/iter |
0.99 |
E2E_Compiler_cmake_presets |
27172796.884621255 ns/iter |
27838494.759998865 ns/iter |
0.98 |
E2E_Compiler_code_climate |
2847683.575510018 ns/iter |
2854619.5162599045 ns/iter |
1.00 |
E2E_Compiler_cql2 |
14064228.880001793 ns/iter |
14144557.62000216 ns/iter |
0.99 |
E2E_Compiler_cspell |
24141276.793098487 ns/iter |
24533646.82142072 ns/iter |
0.98 |
E2E_Compiler_cypress |
4152220.213018423 ns/iter |
4201713.245509349 ns/iter |
0.99 |
E2E_Compiler_deno |
8340468.476189602 ns/iter |
8373115.566266541 ns/iter |
1.00 |
E2E_Compiler_dependabot |
4245693.933332653 ns/iter |
4270954.451219107 ns/iter |
0.99 |
E2E_Compiler_draft_04 |
2981153.7829786213 ns/iter |
2963800.6286924547 ns/iter |
1.01 |
E2E_Compiler_fabric_mod |
5216695.014814831 ns/iter |
5220804.447761641 ns/iter |
1.00 |
E2E_Compiler_geojson |
24133076.24137501 ns/iter |
24626007.928572692 ns/iter |
0.98 |
E2E_Compiler_gitpod_configuration |
5367019.396947169 ns/iter |
5352835.02290093 ns/iter |
1.00 |
E2E_Compiler_helm_chart_lock |
761960.9999999271 ns/iter |
739393.3541225912 ns/iter |
1.03 |
E2E_Compiler_importmap |
312405.6268990282 ns/iter |
301333.60457097087 ns/iter |
1.04 |
E2E_Compiler_jasmine |
1484722.9765956264 ns/iter |
1473845.5010571822 ns/iter |
1.01 |
E2E_Compiler_jshintrc |
4713320.614864396 ns/iter |
4700904.785234239 ns/iter |
1.00 |
E2E_Compiler_jsconfig |
23675533.3333349 ns/iter |
23642080.366668474 ns/iter |
1.00 |
E2E_Compiler_krakend |
144744387.6000307 ns/iter |
146016604.80002466 ns/iter |
0.99 |
E2E_Compiler_lazygit |
35575165.19999808 ns/iter |
36577324.89474304 ns/iter |
0.97 |
E2E_Compiler_lerna |
1756734.1850002548 ns/iter |
1732964.9924994328 ns/iter |
1.01 |
E2E_Compiler_nest_cli |
8038569.804598253 ns/iter |
8095142.919540289 ns/iter |
0.99 |
E2E_Compiler_omc |
166160491.4999657 ns/iter |
173026219.74999964 ns/iter |
0.96 |
E2E_Compiler_omnisharp |
7170745.979380824 ns/iter |
7274568.729165765 ns/iter |
0.99 |
E2E_Compiler_openapi |
27250794.423078053 ns/iter |
27360909.538462974 ns/iter |
1.00 |
E2E_Compiler_pre_commit_hooks |
5820208.909834738 ns/iter |
5805305.033334208 ns/iter |
1.00 |
E2E_Compiler_pulumi |
4383571.724999058 ns/iter |
4423772.968355571 ns/iter |
0.99 |
E2E_Compiler_semantic_release |
1726112.5679009706 ns/iter |
1718358.174447479 ns/iter |
1.00 |
E2E_Compiler_stale |
1692321.2149756232 ns/iter |
1682429.7566264325 ns/iter |
1.01 |
E2E_Compiler_stylecop |
6470595.074073639 ns/iter |
6583650.981132502 ns/iter |
0.98 |
E2E_Compiler_tmuxinator |
2134145.2926830654 ns/iter |
2121580.197568221 ns/iter |
1.01 |
E2E_Compiler_ui5 |
49005225.142845385 ns/iter |
51340523.78571141 ns/iter |
0.95 |
E2E_Compiler_ui5_manifest |
325790041.00000477 ns/iter |
335765248.50002444 ns/iter |
0.97 |
E2E_Compiler_unreal_engine_uproject |
4962854.524822929 ns/iter |
5012619.122303051 ns/iter |
0.99 |
E2E_Compiler_vercel |
13179593.981129006 ns/iter |
13347675.538463695 ns/iter |
0.99 |
E2E_Compiler_yamllint |
380511.48697078147 ns/iter |
370497.0281167537 ns/iter |
1.03 |
E2E_Evaluator_adaptivecard |
23494.910529540743 ns/iter |
23663.137079640328 ns/iter |
0.99 |
E2E_Evaluator_ansible_meta |
250524.56001431073 ns/iter |
225410.0318532964 ns/iter |
1.11 |
E2E_Evaluator_aws_cdk |
52095.734534932584 ns/iter |
43530.91240875537 ns/iter |
1.20 |
E2E_Evaluator_babelrc |
102909.46095718237 ns/iter |
84223.11537540522 ns/iter |
1.22 |
E2E_Evaluator_cerebrum_criminal_case |
1304915.160377483 ns/iter |
1395853.2576334826 ns/iter |
0.93 |
E2E_Evaluator_clang_format |
112292.5475959793 ns/iter |
102116.05750888836 ns/iter |
1.10 |
E2E_Evaluator_cmake_presets |
4401462.3037980255 ns/iter |
5293184.429999655 ns/iter |
0.83 |
E2E_Evaluator_code_climate |
186325.72878669726 ns/iter |
160462.26394307538 ns/iter |
1.16 |
E2E_Evaluator_cql2 |
221736.8170770745 ns/iter |
201658.55485175995 ns/iter |
1.10 |
E2E_Evaluator_cspell |
549670.4283387722 ns/iter |
506455.06985297153 ns/iter |
1.09 |
E2E_Evaluator_cypress |
174446.52226113304 ns/iter |
135077.75097049042 ns/iter |
1.29 |
E2E_Evaluator_deno |
333152.51727496315 ns/iter |
274232.6068611762 ns/iter |
1.21 |
E2E_Evaluator_dependabot |
470380.04943228705 ns/iter |
445621.925806453 ns/iter |
1.06 |
E2E_Evaluator_draft_04 |
6817217.232323993 ns/iter |
8341062.821917972 ns/iter |
0.82 |
E2E_Evaluator_fabric_mod |
768432.1524121524 ns/iter |
712479.625641115 ns/iter |
1.08 |
E2E_Evaluator_geojson |
17111739.190476153 ns/iter |
17637216.349999107 ns/iter |
0.97 |
E2E_Evaluator_gitpod_configuration |
254097.29473689097 ns/iter |
222750.28407639588 ns/iter |
1.14 |
E2E_Evaluator_helm_chart_lock |
326034.42473365006 ns/iter |
214932.62500001508 ns/iter |
1.52 |
E2E_Evaluator_importmap |
48638.412657332265 ns/iter |
41482.347569186444 ns/iter |
1.17 |
E2E_Evaluator_jasmine |
118770.06457036281 ns/iter |
102537.91918897399 ns/iter |
1.16 |
E2E_Evaluator_jshintrc |
1076314.8693008851 ns/iter |
982410.0324860569 ns/iter |
1.10 |
E2E_Evaluator_jsconfig |
415865.5794721268 ns/iter |
371379.19947374606 ns/iter |
1.12 |
E2E_Evaluator_krakend |
208259.58520247226 ns/iter |
183543.8855183459 ns/iter |
1.13 |
E2E_Evaluator_lazygit |
145110.95931702026 ns/iter |
124826.88210227719 ns/iter |
1.16 |
E2E_Evaluator_lerna |
155077.64792504557 ns/iter |
119811.05944358565 ns/iter |
1.29 |
E2E_Evaluator_nest_cli |
193959.46430551008 ns/iter |
177981.404543116 ns/iter |
1.09 |
E2E_Evaluator_omc |
19420.17614404868 ns/iter |
18994.962375090556 ns/iter |
1.02 |
E2E_Evaluator_omnisharp |
552093.4252965285 ns/iter |
511803.0353461191 ns/iter |
1.08 |
E2E_Evaluator_openapi |
13221149.02040994 ns/iter |
15100728.772727674 ns/iter |
0.88 |
E2E_Evaluator_pre_commit_hooks |
532098.8248120256 ns/iter |
477666.9522185336 ns/iter |
1.11 |
E2E_Evaluator_pulumi |
742549.7978835314 ns/iter |
738948.3927036757 ns/iter |
1.00 |
E2E_Evaluator_semantic_release |
104855.28695266627 ns/iter |
86025.01230206533 ns/iter |
1.22 |
E2E_Evaluator_stale |
158932.03717134584 ns/iter |
147052.51340595697 ns/iter |
1.08 |
E2E_Evaluator_stylecop |
310961.8865934093 ns/iter |
288106.2080850244 ns/iter |
1.08 |
E2E_Evaluator_tmuxinator |
99687.7482034813 ns/iter |
86064.88487248284 ns/iter |
1.16 |
E2E_Evaluator_ui5 |
537375.2959573085 ns/iter |
507447.1013960659 ns/iter |
1.06 |
E2E_Evaluator_ui5_manifest |
2787296.5360002127 ns/iter |
2788454.154471573 ns/iter |
1.00 |
E2E_Evaluator_unreal_engine_uproject |
466799.03193605255 ns/iter |
435785.43320844794 ns/iter |
1.07 |
E2E_Evaluator_vercel |
318707.0792931818 ns/iter |
264209.1154281902 ns/iter |
1.21 |
E2E_Evaluator_yamllint |
10850.027583329942 ns/iter |
9162.933960405706 ns/iter |
1.18 |
This comment was automatically generated by workflow using github-action-benchmark.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Juan Cruz Viotti jv@jviotti.com